★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24641Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix comment nits in bootstrap\loaders.js #24641

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@fhinkel fhinkel

@lpinca lpinca

Assignees
No one assigned
Labels
backport-requested-v10.x lib / src
Projects
None yet
Milestone
No milestone
5 participants
@vsemozhetbyt @nodejs-github-bot @fhinkel @lpinca @BethGriggs
@vsemozhetbyt
Copy link
Member

commented Nov 25, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

@vsemozhetbyt vsemozhetbyt added the lib / src label Nov 25, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 25, 2018

As only comments are changed, it seems CI-lite suffices. Let me know if we need full CI.
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 25, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@lpinca

lpinca approved these changes Nov 26, 2018
View changes

@fhinkel

fhinkel approved these changes Nov 27, 2018
View changes

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 27, 2018

Landed in 1db808c
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt closed this Nov 27, 2018

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:lib-internal-bootstrap-loaders.js branch Nov 27, 2018

vsemozhetbyt added a commit that referenced this pull request Nov 27, 2018

@vsemozhetbyt
lib: fix comment nits in bootstrap\loaders.js 
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Loading status checks…
1db808c

targos added a commit that referenced this pull request Nov 27, 2018

@vsemozhetbyt @targos
lib: fix comment nits in bootstrap\loaders.js 
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
90f423d

rvagg added a commit that referenced this pull request Nov 28, 2018

@vsemozhetbyt @rvagg
lib: fix comment nits in bootstrap\loaders.js 
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Loading status checks…
1063e0c

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@vsemozhetbyt @refack
lib: fix comment nits in bootstrap\loaders.js 
PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
8463833

@BethGriggs BethGriggs added the backport-requested-v10.x label Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.