★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24635Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: replace -not with ! in find #24635

Closed
wants to merge 1 commit into from
Closed

build: replace -not with ! in find #24635

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 25, 2018

Replace find -not usage with find ! as -not is not universally
supported.

Fixes: #24634

@nodejs/build-files @rvagg @nodejs/platform-aix

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
build: replace -not with ! in find
5b91604 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 25, 2018

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1698/pipeline

@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2018

👍 here to fast-track

@Trott Trott mentioned this pull request Nov 25, 2018
Closed
@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18957/

lpinca
lpinca approved these changes Nov 25, 2018
View changes
@Trott
Copy link
Member Author

@Trott Trott commented Nov 25, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18959/

@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Nov 25, 2018

landed as e20be47

gireeshpunathil added a commit that referenced this issue Nov 25, 2018
@Trott @gireeshpunathil
build: replace -not with ! in find
e20be47 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this issue Nov 27, 2018
@Trott @targos
build: replace -not with ! in find
059d9c7 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg added a commit that referenced this issue Nov 28, 2018
@Trott @rvagg
build: replace -not with ! in find
3fa4def 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
@beevelop beevelop mentioned this pull request Dec 7, 2018
Closed
@beevelop beevelop mentioned this pull request Dec 7, 2018
Closed
@beevelop beevelop mentioned this pull request Dec 7, 2018
Closed
@beevelop beevelop mentioned this pull request Dec 8, 2018
Closed
@beevelop beevelop mentioned this pull request Dec 8, 2018
Closed
refack added a commit to refack/node that referenced this issue Jan 14, 2019
@Trott @refack
build: replace -not with ! in find
edcc4e6 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: nodejs#24634
PR-URL: nodejs#24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this issue Feb 11, 2019
@Trott @BethGriggs
build: replace -not with ! in find
95a3b3e 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg added a commit that referenced this issue Feb 28, 2019
@Trott @rvagg
build: replace -not with ! in find
748de6b 
Replace `find -not` usage with `find !` as `-not` is not universally
supported.

Fixes: #24634
PR-URL: #24635
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott Trott deleted the notnotnot branch Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@richardlau richardlau

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
aix author ready build fast-track
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

AIX bug in Makefile - find with -not
6 participants
@Trott @nodejs-github-bot @gireeshpunathil @lpinca @richardlau @BethGriggs