★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24632Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promises: emit unhandled warning immediately #24632

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@fhinkel fhinkel

@benjamingr benjamingr

@devsnek devsnek

Assignees
No one assigned
Labels
author ready land-on-v10.x process promises
Projects
None yet
Milestone
No milestone
8 participants
@apapirovski @nodejs-github-bot @Trott @addaleax @fhinkel @benjamingr @devsnek @BethGriggs
@apapirovski
Copy link
Member

apapirovski commented Nov 24, 2018 •
edited

Fixes: #24209

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the process label Nov 24, 2018

@apapirovski apapirovski referenced this pull request Nov 24, 2018

Closed

regression: UnhandledPromiseRejection is not fired until process is terminated #24209

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18947/
@devsnek

devsnek approved these changes Nov 25, 2018
View changes

@benjamingr

benjamingr approved these changes Nov 25, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 25, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18960/

@addaleax addaleax added promises author ready labels Nov 25, 2018

@fhinkel

fhinkel approved these changes Nov 27, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18974/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18979/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

Landed in 3ce9305

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018

@apapirovski @Trott
process: emit unhandled warning immediately 
PR-URL: nodejs#24632
Fixes: nodejs#24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
3ce9305

targos added a commit that referenced this pull request Nov 28, 2018

@apapirovski @targos
process: emit unhandled warning immediately 
PR-URL: #24632
Fixes: #24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
81b42d2

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@apapirovski @refack
process: emit unhandled warning immediately 
PR-URL: nodejs#24632
Fixes: nodejs#24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
2650643

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@apapirovski @BethGriggs
process: emit unhandled warning immediately 
PR-URL: #24632
Fixes: #24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
5bca4c7

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@apapirovski @rvagg
process: emit unhandled warning immediately 
PR-URL: #24632
Fixes: #24209
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
664eed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.