doc: fix replace anonymous function with arrow function #24627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
approved these changes
Nov 24, 2018
oyyd
approved these changes
Nov 24, 2018
It would be nice to change the commit message from fix replace.. to replace..
addaleax
approved these changes
Nov 24, 2018
vsemozhetbyt
approved these changes
Nov 24, 2018
|
Node.js Collaborators, please, add |
|
Landed in 6e4502c (with commit title nit edited). |
vsemozhetbyt
added a commit
that referenced
this issue
Nov 24, 2018
PR-URL: #24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
added a commit
that referenced
this issue
Nov 24, 2018
PR-URL: #24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg
added a commit
that referenced
this issue
Nov 28, 2018
PR-URL: #24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack
added a commit
to refack/node
that referenced
this issue
Jan 14, 2019
PR-URL: nodejs#24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Feb 11, 2019
PR-URL: #24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
rvagg
added a commit
that referenced
this issue
Feb 28, 2019
PR-URL: #24627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes