★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24626Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the arguments order in `assert.strictEqual` #24626

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@fhinkel fhinkel

@Leko Leko

@lpinca lpinca

@watilde watilde

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
code-and-learn test
Projects
None yet
Milestone
No milestone
9 participants
@rt33 @gireeshpunathil @Trott @fhinkel @Leko @lpinca @watilde @cjihrig @nodejs-github-bot
@rt33
Copy link
Contributor

rt33 commented Nov 24, 2018

Update strictEqual arguments order

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 24, 2018

@Leko Leko added the code-and-learn label Nov 24, 2018

@gireeshpunathil

gireeshpunathil approved these changes Nov 24, 2018
View changes

@Leko

Leko approved these changes Nov 24, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 24, 2018
View changes

@lpinca

lpinca approved these changes Nov 24, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18954/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 25, 2018

fast-track? pls 👍
@watilde

watilde approved these changes Nov 26, 2018
View changes

@Leko

Leko approved these changes Nov 26, 2018
View changes

@fhinkel

fhinkel approved these changes Nov 27, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19018/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 29, 2018

Landed in c481799

@Trott Trott closed this Nov 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 29, 2018

@rt33 @Trott
test: fix the arguments order in `assert.strictEqual` 
PR-URL: nodejs#24626
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
c481799

targos added a commit that referenced this pull request Nov 29, 2018

@rt33 @targos
test: fix the arguments order in `assert.strictEqual` 
PR-URL: #24626
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
969ae7a

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@rt33 @refack
test: fix the arguments order in `assert.strictEqual` 
PR-URL: nodejs#24626
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
834c9e5

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@rt33 @BethGriggs
test: fix the arguments order in `assert.strictEqual` 
PR-URL: #24626
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
9f66105

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@rt33 @rvagg
test: fix the arguments order in `assert.strictEqual` 
PR-URL: #24626
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
1d94f3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.