★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24623Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: convert to arrow function #24623

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@joyeecheung joyeecheung

@Leko Leko

@cjihrig cjihrig

@shisama shisama

Assignees
No one assigned
Labels
child_process code-and-learn land-on-v10.x
Projects
None yet
Milestone
No milestone
9 participants
@horihiro @gireeshpunathil @Leko @cjihrig @joyeecheung @shisama @hiroppy @BethGriggs @nodejs-github-bot
@horihiro
Copy link
Contributor

horihiro commented Nov 24, 2018

Converts to Arrow Function

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@horihiro
lib: convert to arrow function
Loading status checks…
db57137

@nodejs-github-bot nodejs-github-bot added the child_process label Nov 24, 2018

@hiroppy hiroppy added the code-and-learn label Nov 24, 2018

@joyeecheung

joyeecheung reviewed Nov 24, 2018
View changes

lib/internal/child_process.js Outdated
@@ -68,25 +68,25 @@ const handleConversion = {
'net.Native': {
simultaneousAccepts: true,

send: function(message, handle, options) {
send: (message, handle, options) => {

This comment has been minimized.

Sign in to view
Copy link
@joyeecheung

joyeecheung Nov 24, 2018

Member

I'd think changing this pattern to something like

send(message, handle, options) {

would be even better?

This comment has been minimized.

Sign in to view
Copy link
@horihiro

horihiro Nov 24, 2018

Author Contributor

Thanks @joyeecheung
I will review my changes according to your suggestion.
@cjihrig

cjihrig approved these changes Nov 25, 2018
View changes

@Leko

Leko approved these changes Nov 26, 2018
View changes

@shisama

shisama approved these changes Nov 28, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 28, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18991/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 28, 2018

landed as b8bd4b4

thank you for @horihiro the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 28, 2018

pull bot pushed a commit to SimenB/node that referenced this pull request Nov 28, 2018

@horihiro @gireeshpunathil
lib: convert to arrow function 
PR-URL: nodejs#24623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
b8bd4b4

targos added a commit that referenced this pull request Nov 28, 2018

@horihiro @targos
lib: convert to arrow function 
PR-URL: #24623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6f42b98

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@horihiro @refack
lib: convert to arrow function 
PR-URL: nodejs#24623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
b30b645

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@horihiro @BethGriggs
lib: convert to arrow function 
PR-URL: #24623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
8f427eb

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@horihiro @rvagg
lib: convert to arrow function 
PR-URL: #24623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
d902d7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.