★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24616Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix http2-binding strictEqual order #24616

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@targos targos

@cjihrig cjihrig

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
code-and-learn fast-track land-on-v10.x test
Projects
None yet
Milestone
No milestone
9 participants
@dominikeinkemmer @gireeshpunathil @Trott @addaleax @targos @cjihrig @joyeecheung @BethGriggs @nodejs-github-bot
@dominikeinkemmer
Copy link
Contributor

dominikeinkemmer commented Nov 24, 2018

Refs: nodejsjp#1

Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@dominikeinkemmer
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js
Loading status checks…
be89026

@nodejs-github-bot nodejs-github-bot added the test label Nov 24, 2018

@addaleax addaleax added the code-and-learn label Nov 24, 2018

@addaleax

addaleax approved these changes Nov 24, 2018
View changes

@joyeecheung

joyeecheung approved these changes Nov 24, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 24, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18922/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

fast-track? pls 👍

@targos targos added the fast-track label Nov 24, 2018

@targos

targos approved these changes Nov 24, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 24, 2018

Landed in a57343c.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 24, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 24, 2018

@dominikeinkemmer @Trott
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: nodejs#24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
a57343c

targos added a commit that referenced this pull request Nov 25, 2018

@dominikeinkemmer @targos
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
37746ef

rvagg added a commit that referenced this pull request Nov 28, 2018

@dominikeinkemmer @rvagg
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
cd1aa2b

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@dominikeinkemmer @refack
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: nodejs#24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
58df0fa

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@dominikeinkemmer @BethGriggs
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
ec70330

@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@dominikeinkemmer @rvagg
test: fix http2-binding strictEqual order 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
98c0fac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.