★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24596Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: convert to arrow function #24596

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@ronkorving ronkorving

@addaleax addaleax

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
code-and-learn land-on-v10.x net
Projects
None yet
Milestone
No milestone
7 participants
@HisadaNaojiro @gireeshpunathil @ronkorving @addaleax @cjihrig @BethGriggs @nodejs-github-bot
@HisadaNaojiro
Copy link
Contributor

HisadaNaojiro commented Nov 24, 2018 •
edited

I changed 1 anonymous functions to arrow functions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@HisadaNaojiro
lib: convert to arrow function
Loading status checks…
7d5ca5a

@nodejs-github-bot nodejs-github-bot added the net label Nov 24, 2018

@ronkorving ronkorving added the code-and-learn label Nov 24, 2018

@ronkorving

ronkorving approved these changes Nov 24, 2018
View changes

@addaleax

addaleax approved these changes Nov 24, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 24, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18926
@cjihrig

cjihrig approved these changes Nov 24, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

Resume CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/22703/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 25, 2018 •
edited

parallel/test-stream-pipeline fails in vs17 of windows that is a known failure and being tracked.
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 26, 2018

landed as 10cc32d

thank you @HisadaNaojiro for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 26, 2018

gireeshpunathil added a commit that referenced this pull request Nov 26, 2018

@HisadaNaojiro @gireeshpunathil
lib: convert to arrow function 
PR-URL: #24596
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Loading status checks…
10cc32d

targos added a commit that referenced this pull request Nov 27, 2018

@HisadaNaojiro @targos
lib: convert to arrow function 
PR-URL: #24596
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c6a6aee

rvagg added a commit that referenced this pull request Nov 28, 2018

@HisadaNaojiro @rvagg
lib: convert to arrow function 
PR-URL: #24596
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
59c2ee0

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@HisadaNaojiro @refack
lib: convert to arrow function 
PR-URL: nodejs#24596
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
cd15651

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@HisadaNaojiro @BethGriggs
lib: convert to arrow function 
PR-URL: #24596
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
1c2ce23

@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@HisadaNaojiro @rvagg
lib: convert to arrow function 
PR-URL: #24596
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
eccd8f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.