★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24594Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assert.strictEqual #24594

Closed
wants to merge 1 commit into from

Conversation

@hyokenmi
Copy link

commented Nov 24, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
feng jianmei feng jianmei
test: fix assert.strictEqual
Loading status checks…
ad01b3f

@nodejs-github-bot nodejs-github-bot added the test label Nov 24, 2018

@ronkorving ronkorving added the code-and-learn label Nov 24, 2018

@addaleax
addaleax approved these changes Nov 24, 2018
View changes
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 24, 2018

looks like #24592 also addresses the same file. can you please discuss with @na9amura and probably pick up another assignment?
@Leko
Leko approved these changes Nov 24, 2018
View changes
@cjihrig
cjihrig approved these changes Nov 24, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18948/

@Trott Trott added the author ready label Nov 25, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 25, 2018

looks like @24592 and #24610 were closed in favor of this; so all set for this PR. fast-track? pls 👍
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18971/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18976/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18981/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

Landed in 46094e4.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018
feng jianmei @Trott
test: fix argument order in assert.strictEqual 
PR-URL: nodejs#24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
46094e4

@hyokenmi hyokenmi deleted the hyokenmi:bugfix-test-child-process-cwd branch Nov 28, 2018

targos added a commit that referenced this pull request Nov 28, 2018
feng jianmei @targos
test: fix argument order in assert.strictEqual 
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
3b99191
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
Merged
4 of 4 tasks complete
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
feng jianmei @refack
test: fix argument order in assert.strictEqual 
PR-URL: nodejs#24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
879a8c3
BethGriggs added a commit that referenced this pull request Feb 12, 2019
feng jianmei @BethGriggs
test: fix argument order in assert.strictEqual 
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
ec7bd18

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
Merged
rvagg added a commit that referenced this pull request Feb 28, 2019
feng jianmei @rvagg
test: fix argument order in assert.strictEqual 
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
73cfbb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@Leko Leko

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready code-and-learn land-on-v10.x test
Projects
None yet
Milestone
No milestone
9 participants
@hyokenmi @gireeshpunathil @Trott @addaleax @Leko @cjihrig @ronkorving @BethGriggs @nodejs-github-bot
You can’t perform that action at this time.