★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24590Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use arrow function #24590

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@addaleax addaleax

@gireeshpunathil gireeshpunathil

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
author ready code-and-learn doc fast-track land-on-v10.x
Projects
None yet
Milestone
No milestone
7 participants
@sadnessOjisan @ronkorving @addaleax @gireeshpunathil @vsemozhetbyt @BethGriggs @nodejs-github-bot
@sadnessOjisan
Copy link
Contributor

sadnessOjisan commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@sadnessOjisan
doc: use arrow function
Loading status checks…
32165b0

@nodejs-github-bot nodejs-github-bot added the doc label Nov 24, 2018

@gireeshpunathil

gireeshpunathil approved these changes Nov 24, 2018
View changes

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 24, 2018

@ronkorving

This comment has been minimized.

Sign in to view
Copy link
Contributor

ronkorving commented Nov 24, 2018

Lintエラーがありそうですね。セミコロンが無くなっちゃたみたいです。
@sadnessOjisan
doc: fix semicolon
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
445e89e
@addaleax

addaleax approved these changes Nov 24, 2018
View changes

@addaleax addaleax added the author ready label Nov 24, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 24, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1689/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

fast-track? 👍
@vsemozhetbyt

vsemozhetbyt approved these changes Nov 24, 2018
View changes

@vsemozhetbyt vsemozhetbyt added the fast-track label Nov 24, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 24, 2018

Landed in 85aa53a
Thank you!

@vsemozhetbyt vsemozhetbyt closed this Nov 24, 2018

vsemozhetbyt added a commit that referenced this pull request Nov 24, 2018

@sadnessOjisan @vsemozhetbyt
doc: use arrow function 
PR-URL: #24590
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Loading status checks…
85aa53a

targos added a commit that referenced this pull request Nov 24, 2018

@sadnessOjisan @targos
doc: use arrow function 
PR-URL: #24590
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
0c16f2a

rvagg added a commit that referenced this pull request Nov 28, 2018

@sadnessOjisan @rvagg
doc: use arrow function 
PR-URL: #24590
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
657d7a5

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@sadnessOjisan @refack
doc: use arrow function 
PR-URL: nodejs#24590
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
94d23ba

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@sadnessOjisan @BethGriggs
doc: use arrow function 
PR-URL: #24590
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
1eeb37c

@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@sadnessOjisan @rvagg
doc: use arrow function 
PR-URL: #24590
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
5babfcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.