★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24589Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: chenged anonymous function to arrow function #24589

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@Trott Trott

@Leko Leko

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
author ready code-and-learn http land-on-v10.x
Projects
None yet
Milestone
No milestone
8 participants
@taishikato @ronkorving @gireeshpunathil @Trott @Leko @cjihrig @BethGriggs @nodejs-github-bot
@taishikato
Copy link
Contributor

taishikato commented Nov 24, 2018

I changed 2 anonymous functions to arrow functions.

Checklist

@nodejs-github-bot nodejs-github-bot added the http label Nov 24, 2018

@taishikato taishikato force-pushed the taishikato:fix-http-clinet-arror-method branch from 5ee7dbd to a90b1d1 Nov 24, 2018

@gireeshpunathil

gireeshpunathil approved these changes Nov 24, 2018
View changes

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 24, 2018

@ronkorving

This comment has been minimized.

Sign in to view
Copy link
Contributor

ronkorving commented Nov 24, 2018

大丈夫そうですが、GitHub descriptionによると２つのfunctionをアローにしましたが、diffを見るなら１つしかないです。その１つは良さそうと思います。
@taishikato

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

taishikato commented Nov 24, 2018 •
edited

@ronkorving 最初は2つ修正したのですが、適切ではなかったため最終的に1つだけにしました
@Leko

Leko approved these changes Nov 24, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18924/
@cjihrig

cjihrig approved these changes Nov 24, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 24, 2018

Whoever lands this should fix up the commit message (chenged -> change).
@Trott

Trott approved these changes Nov 24, 2018
View changes

@gireeshpunathil gireeshpunathil added the author ready label Nov 26, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 26, 2018

landed as 39d25eb

thank you @taishikato for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 26, 2018

gireeshpunathil added a commit that referenced this pull request Nov 26, 2018

@taishikato @gireeshpunathil
lib: change anonymous function to arrow function 
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Loading status checks…
39d25eb

targos added a commit that referenced this pull request Nov 27, 2018

@taishikato @targos
lib: change anonymous function to arrow function 
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
cca8161

rvagg added a commit that referenced this pull request Nov 28, 2018

@taishikato @rvagg
lib: change anonymous function to arrow function 
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
a8e93f7

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@taishikato @refack
lib: change anonymous function to arrow function 
PR-URL: nodejs#24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
4695bd2

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@taishikato @BethGriggs
lib: change anonymous function to arrow function 
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
c87af34

@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@taishikato @rvagg
lib: change anonymous function to arrow function 
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
6277a50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.