★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24581Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix nits in lib/internal/bootstrap/cache.js #24581

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
author ready lib / src
Projects
None yet
Milestone
No milestone
7 participants
@vsemozhetbyt @nodejs-github-bot @Trott @addaleax @lpinca @cjihrig @trivikr
@vsemozhetbyt
Copy link
Member

vsemozhetbyt commented Nov 23, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  • Unwrap short lines.
  • Unify comments.
  • Decrease function calls.
@vsemozhetbyt
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.
Loading status checks…
534785f
@nodejs-github-bot

@vsemozhetbyt vsemozhetbyt added the lib / src label Nov 23, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member Author

vsemozhetbyt commented Nov 23, 2018 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/18901/ ✔️
@lpinca

lpinca approved these changes Nov 23, 2018
View changes

@addaleax

addaleax approved these changes Nov 23, 2018
View changes

@addaleax addaleax added the author ready label Nov 23, 2018

@cjihrig

cjihrig approved these changes Nov 24, 2018
View changes

@trivikr

trivikr approved these changes Nov 24, 2018
View changes

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2018

@vsemozhetbyt @Trott
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: nodejs#24581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
14707b6
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 25, 2018

Landed in 14707b6

@Trott Trott closed this Nov 25, 2018

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:lib-min-func-calls-internal-bootstrap-cache.js branch Nov 25, 2018

targos added a commit that referenced this pull request Nov 27, 2018

@vsemozhetbyt @targos
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
838eecc

rvagg added a commit that referenced this pull request Nov 28, 2018

@vsemozhetbyt @rvagg
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
35a7646

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@vsemozhetbyt @refack
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: nodejs#24581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1a8ef07

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@vsemozhetbyt @BethGriggs
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
9daf175

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@vsemozhetbyt @rvagg
lib: fix nits in lib/internal/bootstrap/cache.js 
* Unwrap short lines.
* Unify comments.
* Decrease function calls.

PR-URL: #24581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
de5d2c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.