★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24571Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document fs.write limitation with TTY #24571

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@sam-github sam-github

@refack refack

@addaleax addaleax

@seishun seishun

@vsemozhetbyt vsemozhetbyt

@gireeshpunathil gireeshpunathil

@mhdawson mhdawson

@bzoz bzoz

Assignees
No one assigned
Labels
author ready doc fs
Projects
None yet
Milestone
No milestone
@mcollina
Copy link
Member

mcollina commented Nov 22, 2018

Fixes: #24550

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added doc fs labels Nov 22, 2018

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 22, 2018

cc @refack @nodejs/platform-windows
@sam-github

sam-github reviewed Nov 22, 2018
View changes

Show resolved Hide resolved doc/api/fs.md Outdated
Show resolved Hide resolved doc/api/fs.md Outdated
@refack

refack approved these changes Nov 22, 2018
View changes

Copy link
Member

refack left a comment

LGTM in general.
I'm rubber-stamping any future phrasing changes.
Show resolved Hide resolved doc/api/fs.md Outdated
Show resolved Hide resolved doc/api/fs.md Outdated
Show resolved Hide resolved doc/api/fs.md Outdated

@mcollina mcollina force-pushed the mcollina:docs-chcp branch from 2ef51f4 to 5fe5b37 Nov 22, 2018

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 22, 2018

Updated with @refack changes (edited).
@sam-github please check it out.
@refack

refack approved these changes Nov 22, 2018
View changes

Copy link
Member

refack left a comment

💯
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 22, 2018

BTW: Is codepage 65001 as UTF-8, is common in POSIX land?
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 22, 2018

BTW: Is codepage 65001 as UTF-8, is common in POSIX land?

I never experienced this problem in Linux or Mac.
@seishun

seishun reviewed Nov 22, 2018
View changes

Show resolved Hide resolved doc/api/fs.md
@mcollina
doc: document fs.write limitation with TTY 
Fixes: #24550
Loading status checks…
3db07ff

@mcollina mcollina force-pushed the mcollina:docs-chcp branch from 5fe5b37 to 3db07ff Nov 22, 2018

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 22, 2018

@seishun PTAL
@mhdawson

mhdawson approved these changes Nov 22, 2018
View changes

Copy link
Member

mhdawson left a comment

LGTM once other peoples comments are addressed
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 23, 2018

I think this should be ready to land after the 48 expires.

@mcollina mcollina added the author ready label Nov 23, 2018

@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1683/
@addaleax

addaleax reviewed Nov 24, 2018
View changes

Show resolved Hide resolved doc/api/fs.md Outdated
@addaleax @mcollina
Update doc/api/fs.md 
Co-Authored-By: mcollina <matteo.collina@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa1e3f4
@seishun

seishun reviewed Nov 24, 2018
View changes

Show resolved Hide resolved doc/api/fs.md
@seishun

seishun reviewed Nov 24, 2018
View changes

Show resolved Hide resolved doc/api/fs.md Outdated
@seishun @mcollina
Update doc/api/fs.md 
Co-Authored-By: mcollina <matteo.collina@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85f4a5b
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcollina commented Nov 26, 2018

I'm going to land this tomorrow morning CET.
@gireeshpunathil

gireeshpunathil approved these changes Nov 26, 2018
View changes

@bzoz

bzoz approved these changes Nov 26, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1703/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

Landed in 086482d

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018

@mcollina @Trott
doc: document fs.write limitation with TTY 
Fixes: nodejs#24550

PR-URL: nodejs#24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
086482d

targos added a commit that referenced this pull request Nov 28, 2018

@mcollina @targos
doc: document fs.write limitation with TTY 
Fixes: #24550

PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
2ebb32b

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@mcollina @refack
doc: document fs.write limitation with TTY 
Fixes: nodejs#24550

PR-URL: nodejs#24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
cd97c5f

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@mcollina @BethGriggs
doc: document fs.write limitation with TTY 
Fixes: #24550

PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
cfd5773

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@mcollina @BethGriggs
doc: document fs.write limitation with TTY 
Fixes: #24550

PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
dbc01e1

rvagg added a commit that referenced this pull request Feb 28, 2019

@mcollina @rvagg
doc: document fs.write limitation with TTY 
Fixes: #24550

PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
4bc212d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.