★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24547Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix session[kSession] undefined issue #24547

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@oyyd oyyd

Assignees
No one assigned
Labels
dont-land-on-v6.x http2 land-on-v10.x
Projects
None yet
Milestone
No milestone
9 participants
@leeight @davedoesdev @oyyd @Trott @jasnell @lpinca @cjihrig @BethGriggs @nodejs-github-bot
@leeight
Copy link
Contributor

commented Nov 21, 2018 •
edited

finishSessionDestroy already done session cleaning up.

Fix: #24546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 labels Nov 21, 2018

@leeight leeight force-pushed the leeight:fix-24546 branch 3 times, most recently from d30c6a3 to 1cd1023 Nov 21, 2018

@oyyd

oyyd reviewed Nov 21, 2018
View changes

Show resolved Hide resolved test/parallel/test-http2-server-session-destroy.js Outdated

@leeight leeight force-pushed the leeight:fix-24546 branch from dc598cc to 1a01a53 Nov 21, 2018

@jasnell

jasnell approved these changes Nov 21, 2018
View changes

@lpinca

lpinca approved these changes Nov 21, 2018
View changes

@davedoesdev

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Nov 21, 2018

@leeight looks good, thanks
@oyyd

oyyd approved these changes Nov 22, 2018
View changes

Show resolved Hide resolved test/parallel/test-http2-server-session-destroy.js Outdated

leeight and others added some commits Nov 21, 2018

@leeight
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` already done session cleaning up.

Fix: #24546
8e5e01c
@oyyd @leeight
https: test/parallel/test-http2-server-session-destroy.js 
Co-Authored-By: leeight <leeight@gmail.com>
Loading status checks…
90e83cd

@leeight leeight force-pushed the leeight:fix-24546 branch from 1a01a53 to 90e83cd Nov 22, 2018

@oyyd

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Nov 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18868/
@cjihrig

cjihrig approved these changes Nov 22, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 25, 2018

Landed in 895fe2f

@Trott Trott closed this Nov 25, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2018

@leeight @Trott
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` session cleanup when already done.

PR-URL: nodejs#24547
Fixes: nodejs#24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
895fe2f

targos added a commit that referenced this pull request Nov 25, 2018

@leeight @targos
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a4c1011

rvagg added a commit that referenced this pull request Nov 28, 2018

@leeight @rvagg
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
091238a

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed

davedoesdev added a commit to davedoesdev/centro that referenced this pull request Dec 7, 2018

@davedoesdev
Use 11.4.0 to pick up nodejs/node#24547
Loading status checks…
0430507

This was referenced Dec 7, 2018

Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@leeight @refack
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` session cleanup when already done.

PR-URL: nodejs#24547
Fixes: nodejs#24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
4bd18a3

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@leeight @BethGriggs
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
c7f876b

@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@leeight @rvagg
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` session cleanup when already done.

PR-URL: #24547
Fixes: #24546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
10f360c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.