★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24542Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:favor arrow function in callback #24542

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@sreepurnajasti sreepurnajasti

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
author ready code-and-learn fast-track test
Projects
None yet
Milestone
No milestone
6 participants
@kotAPI @Trott @cjihrig @gireeshpunathil @sreepurnajasti @nodejs-github-bot
@kotAPI
Copy link
Contributor

kotAPI commented Nov 21, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 21, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 21, 2018

@sreepurnajasti

sreepurnajasti reviewed Nov 21, 2018
View changes

test/parallel/test-zlib-close-after-write.js Outdated
@@ -23,7 +23,7 @@
const common = require('../common');
const zlib = require('zlib');

zlib.gzip('hello', common.mustCall(function(err, out) {
zlib.gzip('hello', common.mustCall((err, out)=> {

This comment has been minimized.

Sign in to view
Copy link
@sreepurnajasti

sreepurnajasti Nov 21, 2018

Contributor

Nit: space is required before arrow to pass the lint test
https://travis-ci.com/nodejs/node/jobs/159977196

This comment has been minimized.

Sign in to view
Copy link
@kotAPI

kotAPI Nov 21, 2018

Author Contributor

I didn't know that, I've pushed again with the required changes, thanks!
@cjihrig

cjihrig approved these changes Nov 21, 2018
View changes

Copy link
Contributor

cjihrig left a comment

LGTM once it passes linting.
@gireeshpunathil

gireeshpunathil approved these changes Nov 21, 2018
View changes

@kotAPI kotAPI force-pushed the kotAPI:master branch from 7f9bc37 to 389c79a Nov 21, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18838/
@kotAPI

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

kotAPI commented Nov 21, 2018

@Trott @cjihrig @sreepurnajasti any tips on how to make the remaining tests pass?
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor

cjihrig commented Nov 21, 2018

It should just be a matter of running it again.

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18856/

@Trott Trott added the author ready label Nov 22, 2018

@kotAPI

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

kotAPI commented Nov 22, 2018

Ahh, thanks @cjihrig :D
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

fast-track? please 👍

@Trott Trott added the fast-track label Nov 22, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 22, 2018

@kotAPI @Trott
test: favor arrow function in callback 
PR-URL: nodejs#24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
21522cb
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 22, 2018

Landed in 21522cb.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 22, 2018

targos added a commit that referenced this pull request Nov 24, 2018

@kotAPI @targos
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
87dc362

rvagg added a commit that referenced this pull request Nov 28, 2018

@kotAPI @rvagg
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
7b0292a

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@kotAPI @codebytere
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
b3e8dba

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@kotAPI @refack
test: favor arrow function in callback 
PR-URL: nodejs#24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
a87b85e

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@kotAPI @MylesBorins
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
3fc4f80

codebytere added a commit that referenced this pull request Jan 29, 2019

@kotAPI @codebytere
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
54abfda

codebytere added a commit that referenced this pull request Jan 29, 2019

@kotAPI @codebytere
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
45d1d03

codebytere added a commit that referenced this pull request Jan 29, 2019

@kotAPI @codebytere
test: favor arrow function in callback 
PR-URL: #24542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d41c988

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.