★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24527Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace anonymous function with arrow function #24527

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@addaleax addaleax

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready code-and-learn test
Projects
None yet
Milestone
No milestone
6 participants
@codegagan @gireeshpunathil @jasnell @addaleax @cjihrig @nodejs-github-bot
@codegagan
Copy link
Contributor

codegagan commented Nov 20, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 20, 2018

@addaleax

addaleax approved these changes Nov 20, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 20, 2018
View changes

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 21, 2018

@jasnell

jasnell approved these changes Nov 21, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18875/

@gireeshpunathil gireeshpunathil added the author ready label Nov 23, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 23, 2018

landed as ccd1ed9

@gireeshpunathil gireeshpunathil closed this Nov 23, 2018

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Nov 23, 2018

@codegagan @gireeshpunathil
test: replace anonymous function with arrow 
PR-URL: nodejs#24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Loading status checks…
ccd1ed9

targos added a commit that referenced this pull request Nov 24, 2018

@codegagan @targos
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
21895e9

rvagg added a commit that referenced this pull request Nov 28, 2018

@codegagan @rvagg
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
39adfc8

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@codegagan @codebytere
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
194bf96

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@codegagan @refack
test: replace anonymous function with arrow 
PR-URL: nodejs#24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
af5e61d

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@codegagan @MylesBorins
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
e295268

codebytere added a commit that referenced this pull request Jan 29, 2019

@codegagan @codebytere
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
088b0db

codebytere added a commit that referenced this pull request Jan 29, 2019

@codegagan @codebytere
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
6415abb

codebytere added a commit that referenced this pull request Jan 29, 2019

@codegagan @codebytere
test: replace anonymous function with arrow 
PR-URL: #24527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
af6de29

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.