★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24513Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change callback to ES6 style #24513

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@Trott Trott

@jasnell jasnell

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
code-and-learn land-on-v10.x landed test
Projects
None yet
Milestone
No milestone
@jamesgeorge007
Copy link
Contributor

jamesgeorge007 commented Nov 20, 2018 •
edited

Converted the es5 functions present within the test/pummel/test-net-pause.js to arrow (es6) functions which is more concise.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 20, 2018

@BridgeAR

BridgeAR approved these changes Nov 20, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 20, 2018
View changes

@jasnell

jasnell approved these changes Nov 21, 2018
View changes

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 21, 2018

@Trott

Trott reviewed Nov 21, 2018
View changes

Show resolved Hide resolved test/pummel/test-net-pause.js Outdated
@jamesgeorge007

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jamesgeorge007 commented Nov 21, 2018

@Trott What do you think now?
@gireeshpunathil

gireeshpunathil approved these changes Nov 22, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18874/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

earlier CI run was aborted. new CI: https://ci.nodejs.org/job/node-test-pull-request/18879/

@addaleax addaleax dismissed Trott’s stale review Nov 23, 2018

addressed

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 23, 2018

@jamesgeorge007 If you could rebase out the merge commit here, that could help – our CI doesn’t play well with those.

CI (rebasing disabled): https://ci.nodejs.org/job/node-test-pull-request/18890/

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch from da24ccb to 8e3c6e6 Nov 23, 2018

@jamesgeorge007 jamesgeorge007 closed this Nov 23, 2018

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch from 8e3c6e6 to b32c5f0 Nov 23, 2018

@jamesgeorge007 jamesgeorge007 reopened this Nov 23, 2018

@jamesgeorge007

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jamesgeorge007 commented Nov 23, 2018 •
edited

@addaleax My working tree became dirty. Hence, I had to close the PR and reopen it again.
Hope everythings fine now 👍
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 23, 2018

@jamesgeorge007 Hm … I think the linter failure from https://travis-ci.com/nodejs/node/jobs/160538871 is real:

$ make lint
make[1]: Entering directory `/home/travis/build/nodejs/node'
Running JS linter...
/home/travis/build/nodejs/node/test/pummel/test-net-pause.js
  91:4  error  Newline required at end of file but not found  eol-last
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18910/

@addaleax addaleax added the author ready label Nov 24, 2018

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch 2 times, most recently from 2947c85 to d32d64c Nov 24, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18914/
@trivikr

trivikr approved these changes Nov 24, 2018
View changes

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch from 2aa26f9 to fbce410 Nov 24, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18940/

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch 3 times, most recently from 17a9ef5 to b62fe77 Nov 24, 2018

@Trott

Trott reviewed Nov 25, 2018
View changes

Show resolved Hide resolved test/pummel/test-net-pause.js Outdated

@Trott Trott removed the author ready label Nov 25, 2018

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch 3 times, most recently from cdb949f to dee06f8 Nov 25, 2018

@jamesgeorge007
test: convert callback to arrow function 
add newline at EOF 👍

Add EOF 👍

fix 👍

fix 👍

fix 👍
Loading status checks…
b210dc2

@jamesgeorge007 jamesgeorge007 force-pushed the jamesgeorge007:patch-1 branch from dee06f8 to b210dc2 Nov 25, 2018

@jamesgeorge007 jamesgeorge007 changed the title Convert functions to es6 style Change callback to ES6 style Nov 25, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 25, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18961/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 25, 2018

landed as afab340

thank you @jamesgeorge007 for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 25, 2018

gireeshpunathil added a commit that referenced this pull request Nov 25, 2018

@jamesgeorge007 @gireeshpunathil
test: convert callback to arrow function 
PR-URL: #24513
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
afab340
@jamesgeorge007

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jamesgeorge007 commented Nov 25, 2018

👍
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 25, 2018

@gireeshpunathil What was the reason behind closing this PR instead of merging? Just curious

@jamesgeorge007 - don't worry; your code is landed as afab340 into the repo, and you have become a contributor in the project.

@refack refack added the landed label Nov 25, 2018

targos added a commit that referenced this pull request Nov 27, 2018

@jamesgeorge007 @targos
test: convert callback to arrow function 
PR-URL: #24513
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e7b5187

rvagg added a commit that referenced this pull request Nov 28, 2018

@jamesgeorge007 @rvagg
test: convert callback to arrow function 
PR-URL: #24513
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
a82b420

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@jamesgeorge007 @refack
test: convert callback to arrow function 
PR-URL: nodejs#24513
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
7601157

BethGriggs added a commit that referenced this pull request Feb 11, 2019

@jamesgeorge007 @BethGriggs
test: convert callback to arrow function 
PR-URL: #24513
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
372073e

@BethGriggs BethGriggs added the land-on-v10.x label Feb 11, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@jamesgeorge007 @rvagg
test: convert callback to arrow function 
PR-URL: #24513
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
c779ca0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.