★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24505Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,src: sync `/src/` files with node.gyp #24505

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Reviewers

@indutny indutny

@danbev danbev

@richardlau richardlau

Assignees
No one assigned
Labels
C++ build gyp lib / src
Projects
None yet
Milestone
No milestone
6 participants
@refack @nodejs-github-bot @Trott @indutny @danbev @richardlau
@refack
Copy link
Member

commented Nov 20, 2018 •
edited

Add missing files. Sort .cpp and .h blocks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 20, 2018

@refack sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the build label Nov 20, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18782/

@refack refack added C++ lib / src labels Nov 20, 2018

@refack refack self-assigned this Nov 20, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 26, 2018

/CC @nodejs/build-files

@refack refack requested a review from danbev Nov 26, 2018

@refack refack added the gyp label Nov 26, 2018

@richardlau

richardlau approved these changes Nov 26, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 26, 2018

A second review on this one would be nice. /ping @danbev @addaleax @bnoordhuis @indutny @jasnell
@danbev

danbev approved these changes Nov 26, 2018
View changes

@indutny

indutny approved these changes Nov 26, 2018
View changes

Copy link
Member

left a comment

LGTM with a question.
node.gyp
@@ -583,6 +597,8 @@
'src/node_crypto.h',
'src/node_crypto_bio.h',
'src/node_crypto_clienthello.h',
'src/node_crypto_clienthello-inl.h',
'src/node_crypto_groups.h',

This comment has been minimized.

Sign in to view
Copy link
@indutny

indutny Nov 26, 2018

Member

Are headers really necessary here at all?

This comment has been minimized.

Sign in to view
Copy link
@refack

refack Nov 26, 2018

Author Member

Sort of... they are added as dependencies for MSBuild and ninja. Also they are added to the MSVS GUI + intellisense + static analysis.
image

This comment has been minimized.

Sign in to view
Copy link
@refack

refack Nov 26, 2018

Author Member

Maybe also relevant for XCode, and compile_commands.json
@refack
build,src: sync src files with node.gyp 
PR-URL: #24505
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Loading status checks…
4b08614

@refack refack force-pushed the refack:sync-src-file branch from 903aa1c to 4b08614 Nov 26, 2018

@refack refack merged commit 4b08614 into nodejs:master Nov 26, 2018

@refack refack deleted the refack:sync-src-file branch Nov 26, 2018

targos added a commit that referenced this pull request Nov 27, 2018

@refack @targos
build,src: sync src files with node.gyp 
PR-URL: #24505
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6588160

rvagg added a commit that referenced this pull request Nov 28, 2018

@refack @rvagg
build,src: sync src files with node.gyp 
PR-URL: #24505
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
bd4df5b

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@refack
build,src: sync src files with node.gyp 
PR-URL: nodejs#24505
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
0d3c62a

@refack refack removed their assignment Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.