★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24489Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing closure function to arrow #24489

Closed
wants to merge 1 commit into from

Conversation

@manilson
Copy link

commented Nov 19, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added C++ intl labels Nov 19, 2018

@gireeshpunathil gireeshpunathil added code-and-learn test and removed C++ intl labels Nov 19, 2018

@gireeshpunathil
gireeshpunathil approved these changes Nov 19, 2018
View changes
@jasnell
jasnell approved these changes Nov 19, 2018
View changes
@fhinkel
fhinkel approved these changes Nov 20, 2018
View changes
@thefourtheye
thefourtheye approved these changes Nov 20, 2018
View changes
@BridgeAR
BridgeAR approved these changes Nov 20, 2018
View changes
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 20, 2018

@manilson - if you like, you could fix the linter errors:
https://travis-ci.com/nodejs/node/jobs/159488942#L1420
https://travis-ci.com/nodejs/node/jobs/159488942#L1424
Maya Anilson @manilson
test: replace closure with arrow function
Loading status checks…
97a7d7f

@manilson manilson force-pushed the manilson:arrow branch from 841fbb6 to 97a7d7f Nov 20, 2018

@cjihrig
cjihrig approved these changes Nov 20, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18834/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 21, 2018

all good, waiting for either 72 hours to pass or I get few fast track 👍
gireeshpunathil added a commit that referenced this pull request Nov 22, 2018
Maya Anilson @gireeshpunathil
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Loading status checks…
4d35fa7
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 22, 2018

landed as 4d35fa7 , thanks!

@gireeshpunathil gireeshpunathil closed this Nov 22, 2018

targos added a commit that referenced this pull request Nov 24, 2018
Maya Anilson @targos
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
86d5a77
rvagg added a commit that referenced this pull request Nov 28, 2018
Maya Anilson @rvagg
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
c28ec86
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
Merged
4 of 4 tasks complete
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere added a commit that referenced this pull request Jan 13, 2019
Maya Anilson @codebytere
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
94e54dc
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
Maya Anilson @refack
test: replace closure with arrow function 
PR-URL: nodejs#24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
4ca7f99
@codebytere codebytere referenced this pull request Jan 15, 2019
Merged
MylesBorins added a commit that referenced this pull request Jan 29, 2019
Maya Anilson @MylesBorins
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
df50f15
codebytere added a commit that referenced this pull request Jan 29, 2019
Maya Anilson @codebytere
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
7dd6485
codebytere added a commit that referenced this pull request Jan 29, 2019
Maya Anilson @codebytere
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
0530fbf
codebytere added a commit that referenced this pull request Jan 29, 2019
Maya Anilson @codebytere
test: replace closure with arrow function 
PR-URL: #24489
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
31511c5
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel

@jasnell jasnell

@thefourtheye thefourtheye

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
code-and-learn test
Projects
None yet
Milestone
No milestone
9 participants
@manilson @gireeshpunathil @Trott @fhinkel @jasnell @thefourtheye @cjihrig @BridgeAR @nodejs-github-bot
You can’t perform that action at this time.