★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24484Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.py: Use print() function in both Python 2 and 3 #24484

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Reviewers

@refack refack

@jasnell jasnell

@addaleax addaleax

@targos targos

@richardlau richardlau

Assignees
No one assigned
Labels
build fast-track python
Projects
None yet
Milestone
No milestone
7 participants
@cclauss @refack @jasnell @addaleax @targos @richardlau @nodejs-github-bot
@cclauss
Copy link
Contributor

cclauss commented Nov 19, 2018 •
edited

A subset of #23669 to simplify the review process. @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build label Nov 19, 2018

@cclauss cclauss changed the title Use print() function in both Python 2 and 3 configure.py: Use print() function in both Python 2 and 3 Nov 19, 2018

@addaleax

addaleax approved these changes Nov 19, 2018
View changes

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@richardlau

richardlau approved these changes Nov 19, 2018
View changes

@refack

refack approved these changes Nov 19, 2018
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 19, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/18766/ (AIX flaked with #22762, Windows flaked with #24497 and #24456)

@refack refack added python author ready fast-track labels Nov 19, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 19, 2018

Reviewers please 👍 for fast-tracking this. It's a simple refactoring to non-code tooling.
@targos

targos approved these changes Nov 19, 2018
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 19, 2018

Resume: https://ci.nodejs.org/job/node-test-pull-request/18770/
cclauss @refack
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Loading status checks…
278126c

@refack refack force-pushed the cclauss:patch-1 branch from d0f09c5 to 278126c Nov 19, 2018

@refack refack removed the author ready label Nov 19, 2018

@refack refack merged commit 278126c into nodejs:master Nov 19, 2018
2 checks passed

2 checks passed

node-test-commit tests passed
Details
node-test-commit-aix tests passed
Details

targos added a commit that referenced this pull request Nov 19, 2018

cclauss @targos
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
d979d22

@cclauss cclauss deleted the cclauss:patch-1 branch Nov 19, 2018

rvagg added a commit that referenced this pull request Nov 28, 2018

cclauss @rvagg
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
21e59a6

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

cclauss @codebytere
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
83d35f4

codebytere added a commit that referenced this pull request Jan 13, 2019

cclauss @codebytere
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
9967d0f

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

cclauss @refack
build: use print() function in configure.py 
PR-URL: nodejs#24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
522819b

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

cclauss @MylesBorins
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
3b8a5e3

codebytere added a commit that referenced this pull request Jan 29, 2019

cclauss @codebytere
build: use print() function in configure.py 
PR-URL: #24484
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
5c3736a

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.