★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24482Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-child-process-env to use arrow functions #24482

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@jasnell jasnell

@thefourtheye thefourtheye

@addaleax addaleax

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@Trott Trott

Assignees
No one assigned
Labels
code-and-learn land-on-v10.x test
Projects
None yet
Milestone
No milestone
10 participants
@sagirk @gireeshpunathil @Trott @jasnell @thefourtheye @addaleax @cjihrig @BridgeAR @BethGriggs @nodejs-github-bot
@sagirk
Copy link
Member

sagirk commented Nov 19, 2018 •
edited

In test/parallel/test-child-process-env.js, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to this,
super or arguments. This results in shorter functions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 19, 2018

@gireeshpunathil

gireeshpunathil approved these changes Nov 19, 2018
View changes

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 19, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18757/
@addaleax

addaleax approved these changes Nov 19, 2018
View changes

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@thefourtheye

thefourtheye approved these changes Nov 20, 2018
View changes

Show resolved Hide resolved test/parallel/test-child-process-env.js
@BridgeAR

BridgeAR approved these changes Nov 20, 2018
View changes

@sagirk

This comment has been minimized.

Sign in to view
Copy link
Member Author

sagirk commented Nov 20, 2018 •
edited

@thefourtheye The build failed, seemingly because of the last change.

How do I go about fixing it? Undoing the common.mustCall wrapper will fix it, but I want to understand if there's something else that we can do here.

image
@cjihrig

cjihrig approved these changes Nov 20, 2018
View changes

@Trott

Trott reviewed Nov 20, 2018
View changes

Copy link
Member

Trott left a comment

Please remove the use of common.mustCall() as an exit event handler. Thanks!

sagirk added some commits Nov 19, 2018

@sagirk
test: refactor test-child-process-env to use arrow functions 
In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.
0767eba
@sagirk
test: wrap functions containing assertions inside a `common.mustCall`
91fa0e1
@sagirk
Revert "test: wrap functions containing assertions inside a `common.m… 
…ustCall`"

This reverts commit 91fa0e1.
Loading status checks…
dc4bdab

@sagirk sagirk force-pushed the sagirk:refactor/test-child-process-env branch from a70411b to dc4bdab Nov 21, 2018

@sagirk sagirk referenced this pull request Nov 21, 2018

Closed

test: refactor test-cluster-send-deadlock to use arrow functions #24479

2 of 4 tasks complete
@sagirk

This comment has been minimized.

Sign in to view
Copy link
Member Author

sagirk commented Nov 21, 2018

@Trott Done. Build passed. PTAL.
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18873/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

windows-fanned test unrelated:

03:38:14 not ok 284 parallel/test-trace-events-worker-metadata
03:38:14   ---
03:38:14   duration_ms: 8.340
03:38:14   severity: fail
03:38:14   exitcode: 1
03:38:14   stack: |-
03:38:14     assert.js:351
03:38:14         throw err;
03:38:14         ^
03:38:14     
03:38:14     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
03:38:14     
03:38:14       assert(traces.some((trace) =>
03:38:14         trace.cat === '__metadata' && trace.name === 'thread_name' &&
03:38:14           trace.args.name === 'WorkerThread 1'))
03:38:14     
03:38:14         at fs.readFile.common.mustCall (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-trace-events-worker-metadata.js:26:7)
03:38:14         at /home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:346:15
03:38:14         at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:54:3)
03:38:14   ...
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 22, 2018

so all is good, just waiting for @Trott to re-review and dismiss the change request.

@Trott Trott dismissed their stale review Nov 26, 2018

requested changes applied

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18989/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 28, 2018

landed as 484ad3b

@gireeshpunathil gireeshpunathil closed this Nov 28, 2018

gireeshpunathil added a commit that referenced this pull request Nov 28, 2018

@sagirk @gireeshpunathil
test: use arrow function 
In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: #24482
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Loading status checks…
484ad3b

targos added a commit that referenced this pull request Nov 28, 2018

@sagirk @targos
test: use arrow function 
In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: #24482
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
0a492c7

@sagirk sagirk deleted the sagirk:refactor/test-child-process-env branch Nov 30, 2018

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed

This was referenced Dec 7, 2018

Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@sagirk @refack
test: use arrow function 
In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: nodejs#24482
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
82b04fc

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@sagirk @BethGriggs
test: use arrow function 
In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: #24482
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
2318c7f

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@sagirk @rvagg
test: use arrow function 
In `test/parallel/test-child-process-env.js`, callbacks use
anonymous closure functions. It is safe to replace them with arrow
functions since these callbacks don't contain references to `this`,
`super` or `arguments`. This results in shorter functions.

PR-URL: #24482
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
5770c52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.