★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24481Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace anonymous closure with arrow functions #24481

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@fhinkel fhinkel

@jasnell jasnell

@thefourtheye thefourtheye

@addaleax addaleax

@cjihrig cjihrig

@sagirk sagirk

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready code-and-learn test
Projects
None yet
Milestone
No milestone
@suman-mitra
Copy link
Contributor

suman-mitra commented Nov 19, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 19, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 19, 2018

@gireeshpunathil

gireeshpunathil approved these changes Nov 19, 2018
View changes

@sagirk

sagirk approved these changes Nov 19, 2018
View changes

Copy link
Member

sagirk left a comment

LGTM! 🎉
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18756/
@addaleax

addaleax approved these changes Nov 19, 2018
View changes

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@fhinkel

fhinkel approved these changes Nov 20, 2018
View changes

@thefourtheye

thefourtheye approved these changes Nov 20, 2018
View changes

@BridgeAR

BridgeAR approved these changes Nov 20, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 20, 2018
View changes

@Trott Trott added the author ready label Nov 21, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2018

@suman-mitra @Trott
test: replace anonymous closure with arrow functions 
PR-URL: nodejs#24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
0bf743a
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 21, 2018

Landed in 0bf743a.

@Trott Trott closed this Nov 21, 2018

targos added a commit that referenced this pull request Nov 21, 2018

@suman-mitra @targos
test: replace anonymous closure with arrow functions 
PR-URL: #24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
a473e9c

rvagg added a commit that referenced this pull request Nov 28, 2018

@suman-mitra @rvagg
test: replace anonymous closure with arrow functions 
PR-URL: #24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
c45660f

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@suman-mitra @codebytere
test: replace anonymous closure with arrow functions 
PR-URL: #24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
a6e595f

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@suman-mitra @refack
test: replace anonymous closure with arrow functions 
PR-URL: nodejs#24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
4f94572

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@suman-mitra @MylesBorins
test: replace anonymous closure with arrow functions 
PR-URL: #24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
e37c257

codebytere added a commit that referenced this pull request Jan 29, 2019

@suman-mitra @codebytere
test: replace anonymous closure with arrow functions 
PR-URL: #24481
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d245f53

@beevelop beevelop referenced this pull request Jan 29, 2019

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere #280

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.