★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24473Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use arraysize instead of hardcode number #24473

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@refack refack

@lpinca lpinca

@jasnell jasnell

@addaleax addaleax

@sagirk sagirk

Assignees
No one assigned
Labels
C++ land-on-v10.x os
Projects
None yet
Milestone
No milestone
8 participants
@leeight @addaleax @refack @jasnell @lpinca @sagirk @BethGriggs @nodejs-github-bot
@leeight
Copy link
Contributor

leeight commented Nov 19, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added C++ os labels Nov 19, 2018

@leeight leeight force-pushed the leeight:use-arrarysize branch 3 times, most recently from a52e8d4 to 2c35649 Nov 19, 2018

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@addaleax

addaleax approved these changes Nov 19, 2018
View changes

@sagirk

sagirk approved these changes Nov 19, 2018
View changes

@leeight leeight force-pushed the leeight:use-arrarysize branch from 2c35649 to cb4a1b1 Nov 20, 2018

@lpinca

lpinca reviewed Nov 20, 2018
View changes

Show resolved Hide resolved src/node_url.cc Outdated

@leeight leeight force-pushed the leeight:use-arrarysize branch from cb4a1b1 to c05fa48 Nov 21, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18895/

@addaleax addaleax added the author ready label Nov 23, 2018

@refack

refack reviewed Nov 23, 2018
View changes

Copy link
Member

refack left a comment

Added three suggestions.
Show resolved Hide resolved src/node_os.cc Outdated

@leeight leeight force-pushed the leeight:use-arrarysize branch from c05fa48 to f059332 Nov 23, 2018

@refack

refack approved these changes Nov 23, 2018
View changes

Copy link
Member

refack left a comment

💯 Thanks you!

@leeight leeight force-pushed the leeight:use-arrarysize branch from f059332 to 22fc963 Nov 23, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 23, 2018

Looks like the most recent changes broke Travis?

@addaleax addaleax removed the author ready label Nov 23, 2018

@refack

refack reviewed Nov 24, 2018
View changes

Show resolved Hide resolved src/node_os.cc Outdated

@leeight leeight force-pushed the leeight:use-arrarysize branch from 22fc963 to 49ada82 Nov 24, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 24, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18930/
@refack

refack approved these changes Nov 24, 2018
View changes

@refack refack added the author ready label Nov 24, 2018

@addaleax

addaleax requested changes Nov 24, 2018
View changes

Show resolved Hide resolved src/util.h Outdated

@addaleax addaleax removed the author ready label Nov 24, 2018

@addaleax @leeight
src: Update src/util.h 
Co-Authored-By: leeight <leeight@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c0a94ef
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 24, 2018 •
edited by Trott

New CI: https://ci.nodejs.org/job/node-test-pull-request/18941/ ✔️

@refack refack self-assigned this Nov 24, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 24, 2018 •
edited

P.S. I'm self-assigned this so I'll get notifications from GitHub, and so that I will not lose track of it and help steward it to completion.
@addaleax

addaleax approved these changes Dec 1, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Dec 1, 2018

Landed in adbf947, thanks for the PR! 🎉

By the way, if your PR doesn’t receive much attention within a day or two, and you think it’s ready to go, feel free to bump the thread by commenting (e.g. “bump” or pinging involved individuals like me). 🙂

@addaleax addaleax closed this Dec 1, 2018

addaleax added a commit that referenced this pull request Dec 1, 2018

@leeight @addaleax
src: use arraysize instead of hardcode number 
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
adbf947

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@leeight @BridgeAR
src: use arraysize instead of hardcode number 
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
ecbe616

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@leeight @refack
src: use arraysize instead of hardcode number 
PR-URL: nodejs#24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
09a6b7a

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@leeight @BethGriggs
src: use arraysize instead of hardcode number 
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
37047fc

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@leeight @rvagg
src: use arraysize instead of hardcode number 
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
6b8e200

@refack refack removed their assignment Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.