★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24447Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: remove unreachable branch #24447

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Reviewers

@refack refack

@jasnell jasnell

@addaleax addaleax

@sagirk sagirk

@starkwang starkwang

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
code-and-learn util
Projects
None yet
Milestone
No milestone
9 participants
@rahulshuklab4u @Trott @refack @addaleax @jasnell @sagirk @starkwang @gireeshpunathil @nodejs-github-bot
@rahulshuklab4u
Copy link
Contributor

rahulshuklab4u commented Nov 17, 2018

Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util label Nov 17, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 17, 2018

/ping @nodejs/util (especially @BridgeAR)
@addaleax

addaleax approved these changes Nov 17, 2018
View changes

@refack

refack approved these changes Nov 17, 2018
View changes

@refack refack requested a review from BridgeAR Nov 17, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 17, 2018 •
edited

Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

Also since value passes an isArray test, it is guaranteed to have a non negative, defined length property

node/lib/internal/util/inspect.js

Lines 476 to 479 in bde132b

} else if (Array.isArray(value)) {
const clazz = Object.getPrototypeOf(value) ||
clazzWithNullPrototype(Array, 'Array');
newVal = new clazz(value.length || 0);

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 17, 2018

Hello @rahulshuklab4u and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.
@starkwang

starkwang approved these changes Nov 18, 2018
View changes

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 18, 2018

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@sagirk

sagirk approved these changes Nov 19, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18801/

@addaleax addaleax added the author ready label Nov 20, 2018

@rahulshuklab4u @refack
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
fbc2916

@refack refack force-pushed the rahulshuklab4u:master branch from 58b3b9f to fbc2916 Nov 20, 2018

@refack refack removed the author ready label Nov 20, 2018

@refack refack merged commit fbc2916 into nodejs:master Nov 20, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 20, 2018

Congratulations @rahulshuklab4u on getting promoted by GitHub from:
image
to:
image

🎉

targos added a commit that referenced this pull request Nov 21, 2018

@rahulshuklab4u @targos
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
519b621

rvagg added a commit that referenced this pull request Nov 28, 2018

@rahulshuklab4u @rvagg
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
9e8f91d

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@rahulshuklab4u @codebytere
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
734fe5f

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@rahulshuklab4u @refack
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: nodejs#24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
7a0d9d3

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@rahulshuklab4u @MylesBorins
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
b52a3c9

codebytere added a commit that referenced this pull request Jan 29, 2019

@rahulshuklab4u @codebytere
util: remove unreachable branch 
Re-defining the array length will always set to 0.
Hence, the code branch can not be covered.

PR-URL: #24447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
eeb4715

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.