★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24446Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor setupInspector in bootstrap/node.js #24446

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@danbev danbev

@jasnell jasnell

@oyyd oyyd

Assignees
No one assigned
Labels
lib / src
Projects
None yet
Milestone
No milestone
4 participants
@leeight @oyyd @danbev @jasnell
@leeight
Copy link
Contributor

leeight commented Nov 17, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@leeight leeight force-pushed the leeight:clean-bootstrap-node branch from af97483 to fa8b825 Nov 18, 2018

@oyyd

This comment has been minimized.

Sign in to view
Copy link
Contributor

oyyd commented Nov 18, 2018

Hi @leeight. Thanks for your contribution! Can you add a short description about the change in the commit message? As Change-Id: Ic715201ba5eae43f7d535ff93045cb3a965d2752 seems a bit confuzing to me. You can find the guide here (which you may have known about before)
@leeight
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.
Loading status checks…
a4984e6

@leeight leeight force-pushed the leeight:clean-bootstrap-node branch from fa8b825 to a4984e6 Nov 18, 2018

@leeight

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

leeight commented Nov 18, 2018

@oyyd Thanks for your feedback. I updated the commit message and removed the Change-Id.
@oyyd

This comment has been minimized.

Sign in to view
Copy link
Contributor

oyyd commented Nov 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18719/
@oyyd

oyyd approved these changes Nov 18, 2018
View changes

Copy link
Contributor

oyyd left a comment

LGTM

@oyyd oyyd added the lib / src label Nov 18, 2018

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@danbev

danbev approved these changes Nov 20, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Nov 20, 2018

Landed in 771585f.

@danbev danbev closed this Nov 20, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018

@leeight @danbev
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: nodejs#24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
771585f

targos added a commit that referenced this pull request Nov 20, 2018

@leeight @targos
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c331939

rvagg added a commit that referenced this pull request Nov 28, 2018

@leeight @rvagg
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
e14abfe

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@leeight @codebytere
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
522a6ed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@leeight @refack
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: nodejs#24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
00bd032

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@leeight @MylesBorins
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
fe6b70e

codebytere added a commit that referenced this pull request Jan 29, 2019

@leeight @codebytere
lib: refactor setupInspector in bootstrap/node.js 
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
6bd055f

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.