★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24436Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Using arrow functions #24436

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@targos targos

@jasnell jasnell

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
code-and-learn test
Projects
None yet
Milestone
No milestone
6 participants
@NoSkillGirl @gireeshpunathil @danbev @jasnell @targos @nodejs-github-bot
@NoSkillGirl
Copy link
Contributor

NoSkillGirl commented Nov 17, 2018

Using arrow functions in test-tls-client-resume.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 17, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 17, 2018

@targos

targos reviewed Nov 17, 2018
View changes

Copy link
Member

targos left a comment

Commit message should look like test: use arrow functions
test/parallel/test-tls-client-resume.js Outdated
const server = tls.Server(options, common.mustCall(function(socket) {
socket.end('Goodbye');
}, 2));
const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));

This comment has been minimized.

Sign in to view
Copy link
@targos

targos Nov 17, 2018

Member
Suggested change
const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));
const server = tls.Server(options, common.mustCall(socket => socket.end('Goodbye'), 2));

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 0ee9e42 to 75cf1d4 Nov 20, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 20, 2018

@NoSkillGirl
test: Using arrow functions 
 - Using arrow functions in test-tls-client-resume.js

 PR URL: nodejs#24436
75cf1d4

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 75cf1d4 to 362b69d Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018

@NoSkillGirl
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js

    PR-URL: nodejs#24436
362b69d

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 0d6b3c8 to 272d172 Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018

@NoSkillGirl
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Error thrown in Travis - 41:52  error  Expected parentheses around arrow function argument  arrow-parens, This got fixed

    PR-URL: nodejs#24436
272d172

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 272d172 to e12f560 Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018

@NoSkillGirl
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Error thrown in Travis - 41:52  error  Expected parentheses around arrow function argument  arrow-parens, This got fixed

    PR-URL: nodejs#24436
e12f560
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 21, 2018

ping @NoSkillGirl

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from e12f560 to 0dbe2f8 Nov 21, 2018

NoSkillGirl added a commit to NoSkillGirl/node that referenced this pull request Nov 21, 2018

@NoSkillGirl
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function argument arrow-parens

    PR-URL: nodejs#24436
0dbe2f8
@NoSkillGirl

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

NoSkillGirl commented Nov 21, 2018

Pong @gireeshpunathil
@gireeshpunathil

gireeshpunathil approved these changes Nov 21, 2018
View changes

@NoSkillGirl
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

    PR-URL: #24436
Loading status checks…
d91a981

@NoSkillGirl NoSkillGirl force-pushed the NoSkillGirl:testcase-arrowfunctions branch from 0dbe2f8 to d91a981 Nov 21, 2018

@jasnell

jasnell approved these changes Nov 21, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Nov 22, 2018 •
edited

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/18866/ ✔️
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Nov 22, 2018

Landed in 282e533. 🎉

@danbev danbev closed this Nov 22, 2018

danbev added a commit that referenced this pull request Nov 22, 2018

@NoSkillGirl @danbev
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
282e533
@NoSkillGirl

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

NoSkillGirl commented Nov 22, 2018

Thank You @danbev

targos added a commit that referenced this pull request Nov 24, 2018

@NoSkillGirl @targos
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
82ed615

rvagg added a commit that referenced this pull request Nov 28, 2018

@NoSkillGirl @rvagg
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
1cd73a8

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed

This was referenced Dec 8, 2018

Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@NoSkillGirl @codebytere
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
6e7d867

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@NoSkillGirl @refack
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: nodejs#24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
f4319d7

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@NoSkillGirl @MylesBorins
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
1a9d7f9

codebytere added a commit that referenced this pull request Jan 29, 2019

@NoSkillGirl @codebytere
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d71a607

codebytere added a commit that referenced this pull request Jan 29, 2019

@NoSkillGirl @codebytere
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
0a2cd50

codebytere added a commit that referenced this pull request Jan 29, 2019

@NoSkillGirl @codebytere
test: using arrow functions 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
8bd2399

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.