★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24429Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src:Elevate v8 namespaces of repeatedly referenced artifacts with #24429

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@refack refack

@targos targos

@jasnell jasnell

@thefourtheye thefourtheye

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
C++ author ready code-and-learn intl
Projects
None yet
Milestone
No milestone
9 participants
@manilson @targos @refack @Trott @addaleax @jasnell @thefourtheye @gireeshpunathil @nodejs-github-bot
@manilson
Copy link

commented Nov 17, 2018

'using' keyword in src/node_i18n.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added C++ intl labels Nov 17, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 17, 2018

@targos

targos reviewed Nov 17, 2018
View changes

Show resolved Hide resolved src/node_i18n.cc Outdated
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 17, 2018

The commit message should start with src: elevate ... and its first line should be shorter (max 50 characters)
@refack

refack approved these changes Nov 17, 2018
View changes

Copy link
Member

left a comment

LGTM % duplicate line

@refack refack added the fast-track label Nov 17, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 17, 2018

Please 👍 for fast-track (nits could be resolved during landing)
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 17, 2018

Lite CI:https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/
@gireeshpunathil

gireeshpunathil approved these changes Nov 18, 2018
View changes

@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18771/
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 19, 2018

Hello @manilson and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any questions you can also feel free to contact me directly.

P.P.S. If you like you can associate your email address with you GitHub account. That way your contributions will be properly credited to you. See https://help.github.com/articles/setting-your-commit-email-address-on-github/

@refack refack added blocked and removed fast-track labels Nov 19, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 19, 2018

blocking to give the OP a chance to set their email address.
@thefourtheye

thefourtheye approved these changes Nov 20, 2018
View changes

@manilson manilson force-pushed the manilson:master branch from bb5dffe to 4cd7be8 Nov 20, 2018

@addaleax addaleax removed the blocked label Nov 20, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18804/

@addaleax addaleax added the author ready label Nov 20, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 20, 2018

Landed in 77c2cf9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 20, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2018

Maya Anilson @Trott
src: elevate namespaces of repeated artifacts 
PR-URL: nodejs#24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
77c2cf9

targos added a commit that referenced this pull request Nov 21, 2018

Maya Anilson @targos
src: elevate namespaces of repeated artifacts 
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6a5a50d

rvagg added a commit that referenced this pull request Nov 28, 2018

Maya Anilson @rvagg
src: elevate namespaces of repeated artifacts 
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
b8ed930

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed

This was referenced Dec 7, 2018

Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

Maya Anilson @codebytere
src: elevate namespaces of repeated artifacts 
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
ff4eeae

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

Maya Anilson @refack
src: elevate namespaces of repeated artifacts 
PR-URL: nodejs#24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2a68866

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

Maya Anilson @MylesBorins
src: elevate namespaces of repeated artifacts 
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
335872f

codebytere added a commit that referenced this pull request Jan 29, 2019

Maya Anilson @codebytere
src: elevate namespaces of repeated artifacts 
PR-URL: #24429
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
4b82aa8

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.