★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24428Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix actual parameter order for 'assert.strictEqual' #24428

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@targos targos

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@ryzokuken ryzokuken

@trivikr trivikr

Assignees
No one assigned
Labels
code-and-learn fast-track test
Projects
None yet
Milestone
No milestone
8 participants
@SelvarajKaruppusamy @targos @gireeshpunathil @Trott @cjihrig @ryzokuken @trivikr @nodejs-github-bot
@SelvarajKaruppusamy
Copy link
Contributor

SelvarajKaruppusamy commented Nov 17, 2018

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit @@guidelines

This commit is initiated from Code&Learn meetup

@ryzokuken @thefourtheye

@nodejs-github-bot nodejs-github-bot added the test label Nov 17, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 17, 2018

@targos

targos approved these changes Nov 17, 2018
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@cjihrig

cjihrig approved these changes Nov 17, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 18, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18712/
@trivikr

trivikr approved these changes Nov 18, 2018
View changes

@ryzokuken

ryzokuken approved these changes Nov 18, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 19, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18731/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 19, 2018

Landed in 9801eb9

@Trott Trott closed this Nov 19, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018

@SelvarajKaruppusamy @Trott
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: nodejs#24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
9801eb9

targos added a commit that referenced this pull request Nov 19, 2018

@SelvarajKaruppusamy @targos
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: #24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
b2d8361

rvagg added a commit that referenced this pull request Nov 28, 2018

@SelvarajKaruppusamy @rvagg
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: #24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
59723d4

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@SelvarajKaruppusamy @codebytere
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: #24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d73b8f0

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@SelvarajKaruppusamy @refack
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: nodejs#24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
8e703d4

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@SelvarajKaruppusamy @MylesBorins
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: #24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
43a6bb7

codebytere added a commit that referenced this pull request Jan 29, 2019

@SelvarajKaruppusamy @codebytere
test: fix actual parameter order for 'assert.strictEqual' 
PR-URL: #24428
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
c29c510

This was referenced Jan 29, 2019

Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.