★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24423Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace anonymous closure for test-http-expect-handling.js #24423

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@targos targos

@gireeshpunathil gireeshpunathil

@trivikr trivikr

Assignees
No one assigned
Labels
author ready code-and-learn fast-track test
Projects
None yet
Milestone
No milestone
7 participants
@Jayasankar-m @targos @gireeshpunathil @Trott @richardlau @trivikr @nodejs-github-bot
@Jayasankar-m
Copy link
Contributor

Jayasankar-m commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Nov 17, 2018

@Jayasankar-m Jayasankar-m force-pushed the Jayasankar-m:jsnew branch from b79f924 to c792fb7 Nov 17, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 17, 2018

@targos

targos approved these changes Nov 17, 2018
View changes

Copy link
Member

targos left a comment

Changes LGTM.

Commit message should start with test: replace ...
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@gireeshpunathil

gireeshpunathil approved these changes Nov 18, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18711/

@Trott Trott added the author ready label Nov 18, 2018

@trivikr

trivikr approved these changes Nov 18, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 18, 2018

Landed in 1dadaf9

@Trott Trott closed this Nov 18, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 18, 2018

@Jayasankar-m @Trott
test:replace anonymous closure for test-http-expect-handling.js 
PR-URL: nodejs#24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1dadaf9

targos added a commit that referenced this pull request Nov 18, 2018

@Jayasankar-m @targos
test:replace anonymous closure for test-http-expect-handling.js 
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e9fb811
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 18, 2018

@Trott did core-validate-commit accept the message? I'm asking because there should be a space after the colon.
@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member

richardlau commented Nov 18, 2018

@Trott did core-validate-commit accept the message? I'm asking because there should be a space after the colon.

Apparently it did:

https://travis-ci.com/nodejs/node/jobs/159274629#L695-L703

test:replace anonymous closure for test-http-expect-handling.js
+npx -q core-validate-commit --no-validate-metadata https://api.github.com/repos/nodejs/node/commits/c792fb7a10120092bfb3847d76d7691490152226
  ✔  c792fb7a10120092bfb3847d76d7691490152226
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 18, 2018

nodejs/core-validate-commit#35

rvagg added a commit that referenced this pull request Nov 28, 2018

@Jayasankar-m @rvagg
test:replace anonymous closure for test-http-expect-handling.js 
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ffb5e5d

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@Jayasankar-m @codebytere
test:replace anonymous closure for test-http-expect-handling.js 
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
e868fdd

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Jayasankar-m @refack
test:replace anonymous closure for test-http-expect-handling.js 
PR-URL: nodejs#24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
53be6ca

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

codebytere added a commit that referenced this pull request Jan 29, 2019

@Jayasankar-m @codebytere
test:replace anonymous closure for test-http-expect-handling.js 
PR-URL: #24423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
f4c2d9e

@beevelop beevelop referenced this pull request Jan 29, 2019

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere #280

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.