★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24413Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: test: fixed the arguments order in #24227 #24413

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@jasnell jasnell

@targos targos

@cjihrig cjihrig

@oyyd oyyd

@gireeshpunathil gireeshpunathil

@trivikr trivikr

Assignees
No one assigned
Labels
code-and-learn fast-track n-api test
Projects
None yet
Milestone
No milestone
9 participants
@kanishk30 @targos @gireeshpunathil @Trott @jasnell @cjihrig @oyyd @trivikr @nodejs-github-bot
@kanishk30
Copy link
Contributor

kanishk30 commented Nov 17, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added n-api test labels Nov 17, 2018

@gireeshpunathil gireeshpunathil added the code-and-learn label Nov 17, 2018

@targos

targos approved these changes Nov 17, 2018
View changes

Copy link
Member

targos left a comment

Change LGTM.

The commit message should be changed to something like test: fix arguments order in napi test_exception
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@oyyd

oyyd approved these changes Nov 17, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 18, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 18, 2018

@kanishk30 - please state whether you can make the changes that @targos suggested or not. It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!
@trivikr

trivikr approved these changes Nov 18, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 18, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 18, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/18728/
@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 19, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18742/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 19, 2018

Landed in c03c6e9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 19, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018

@kanishk30 @Trott
test: fix arguments order in napi test_exception 
PR-URL: nodejs#24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
c03c6e9

targos added a commit that referenced this pull request Nov 19, 2018

@kanishk30 @targos
test: fix arguments order in napi test_exception 
PR-URL: #24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6bedd17

rvagg added a commit that referenced this pull request Nov 28, 2018

@kanishk30 @rvagg
test: fix arguments order in napi test_exception 
PR-URL: #24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
4348ffe

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@kanishk30 @codebytere
test: fix arguments order in napi test_exception 
PR-URL: #24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d148bfc

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@kanishk30 @refack
test: fix arguments order in napi test_exception 
PR-URL: nodejs#24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
b6576a1

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@kanishk30 @MylesBorins
test: fix arguments order in napi test_exception 
PR-URL: #24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d60d464

codebytere added a commit that referenced this pull request Jan 29, 2019

@kanishk30 @codebytere
test: fix arguments order in napi test_exception 
PR-URL: #24413
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
644a9d6

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.