★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24391Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update to remark-lint-preset-node@1.2.0 #24391

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@jasnell jasnell

@watilde watilde

Assignees
No one assigned
Labels
doc tools
Projects
None yet
Milestone
No milestone
4 participants
@Trott @nodejs-github-bot @jasnell @watilde
@Trott
Copy link
Member

Trott commented Nov 16, 2018

Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)

Minor formatting adjustments to two changelog files in preparation for the new markdown lint rule.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Trott added some commits Nov 16, 2018

@Trott
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.
c12e723
@Trott
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)
Loading status checks…
a905faa

@Trott Trott added doc tools labels Nov 16, 2018

@nodejs-github-bot
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Nov 18, 2018

@nodejs/linting @nodejs/documentation This can use some reviews.
@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@watilde

watilde approved these changes Nov 19, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Nov 19, 2018

Landed in dafd76c...3cac82f

@Trott Trott closed this Nov 19, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018

@Trott
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
51494da

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018

@Trott
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
3cac82f

targos added a commit that referenced this pull request Nov 19, 2018

@Trott @targos
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6c40ef8

targos added a commit that referenced this pull request Nov 19, 2018

@Trott @targos
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a0e369a

rvagg added a commit that referenced this pull request Nov 28, 2018

@Trott @rvagg
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
cf2306d

rvagg added a commit that referenced this pull request Nov 28, 2018

@Trott @rvagg
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
13a4d10

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@Trott @codebytere
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
a1dcb31

codebytere added a commit that referenced this pull request Jan 13, 2019

@Trott @codebytere
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
2864dcf

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Trott @refack
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
aa31c96

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Trott @refack
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
d2ea3ea

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@Trott @MylesBorins
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
80228ec

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@Trott @MylesBorins
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
63a2733

codebytere added a commit that referenced this pull request Jan 29, 2019

@Trott @codebytere
doc: udpate list item spacing in changelogs 
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
a620c25

codebytere added a commit that referenced this pull request Jan 29, 2019

@Trott @codebytere
tools: update to remark-lint-preset-node@1.2.0 
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
cc4d866

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.