★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24375Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove argument and fix import #24375

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@fhinkel fhinkel

@thefourtheye thefourtheye

@Trott Trott

@lpinca lpinca

@cjihrig cjihrig

@starkwang starkwang

@trivikr trivikr

Assignees
No one assigned
Labels
async_hooks author ready test
Projects
None yet
Milestone
No milestone
9 participants
@jkmdev @Trott @fhinkel @thefourtheye @lpinca @cjihrig @starkwang @trivikr @nodejs-github-bot
@jkmdev
Copy link
Contributor

jkmdev commented Nov 15, 2018

Removes unused argument and uses destructuring for spawn import in test-pipewrap.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks test labels Nov 15, 2018

@Trott

Trott approved these changes Nov 15, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18628/
@starkwang

starkwang approved these changes Nov 15, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 15, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 15, 2018 •
edited

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18644/
@thefourtheye

thefourtheye approved these changes Nov 15, 2018
View changes

@lpinca

lpinca approved these changes Nov 15, 2018
View changes

@Trott Trott added the author ready label Nov 16, 2018

@fhinkel

fhinkel approved these changes Nov 16, 2018
View changes

@trivikr

trivikr approved these changes Nov 16, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 17, 2018 •
edited

Landed in 07a7bf7.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 17, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 17, 2018

@jkmdev @Trott
test: use destructuring and remove unused arguments 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: nodejs#24375
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
07a7bf7

targos added a commit that referenced this pull request Nov 18, 2018

@jkmdev @targos
test: use destructuring and remove unused arguments 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
20cdf24

rvagg added a commit that referenced this pull request Nov 28, 2018

@jkmdev @rvagg
test: use destructuring and remove unused arguments 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
7e2a284

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 12, 2019

@jkmdev @codebytere
test: use destructuring and remove unused arguments 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
8ac75c8

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

codebytere added a commit that referenced this pull request Jan 29, 2019

@jkmdev @codebytere
test: use destructuring and remove unused arguments 
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
3b6135f

@beevelop beevelop referenced this pull request Jan 29, 2019

Closed

2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere #280

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.