★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24368Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused function arguments in async-hooks tests #24368

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Nov 14, 2018

Remove unused function arguments in two async-hooks tests.

(This actually started as a bigger change but then I realized the bigger change was wrong. Oops.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: remove unused function arguments in async-hooks tests 
Remove unused function arguments in two async-hooks tests.
Loading status checks…
291ac64
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 14, 2018

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1616/pipeline

@nodejs-github-bot nodejs-github-bot added async_hooks test labels Nov 14, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18617/
@addaleax
addaleax approved these changes Nov 14, 2018
View changes
@lpinca
lpinca approved these changes Nov 14, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 14, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18618/
@mhdawson
mhdawson approved these changes Nov 14, 2018
View changes
Copy link
Member

left a comment

LGTM
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 14, 2018

Took problematic host offline. Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18620/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 16, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18668/
@fhinkel
fhinkel approved these changes Nov 16, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 16, 2018

Landed in b7e9804

@Trott Trott closed this Nov 16, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 16, 2018
@Trott
test: remove unused function arguments in async-hooks tests 
Remove unused function arguments in two async-hooks tests.

PR-URL: nodejs#24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
b7e9804
targos added a commit that referenced this pull request Nov 18, 2018
@Trott @targos
test: remove unused function arguments in async-hooks tests 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
3682561
rvagg added a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
test: remove unused function arguments in async-hooks tests 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
ee64ae0
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
Merged
4 of 4 tasks complete
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere added a commit that referenced this pull request Jan 12, 2019
@Trott @codebytere
test: remove unused function arguments in async-hooks tests 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
979ea16
@codebytere codebytere referenced this pull request Jan 15, 2019
Merged
codebytere added a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
test: remove unused function arguments in async-hooks tests 
Remove unused function arguments in two async-hooks tests.

PR-URL: #24368
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
987df27
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel

@addaleax addaleax

@lpinca lpinca

@mhdawson mhdawson

Assignees
No one assigned
Labels
async_hooks test
Projects
None yet
Milestone
No milestone
6 participants
@Trott @nodejs-github-bot @fhinkel @addaleax @lpinca @mhdawson
You can’t perform that action at this time.