★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24346Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: make Http2ServerResponse#end() always return this #24346

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@mcollina mcollina

@lpinca lpinca

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready dont-land-on-v6.x http2
Projects
None yet
Milestone
No milestone
7 participants
@ronag @lpinca @addaleax @BridgeAR @mcollina @cjihrig @nodejs-github-bot
@ronag
Copy link
Contributor

ronag commented Nov 13, 2018

Http2Response.end can return false instead of this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 labels Nov 13, 2018

@ronag ronag force-pushed the nxtedition:http2-compat-end-return-this branch from 0ab5abc to 11e7f62 Nov 13, 2018

@lpinca

lpinca approved these changes Mar 10, 2019
View changes

@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member

lpinca commented Mar 10, 2019

cc: @nodejs/http2

@lpinca lpinca changed the title Http2 compat end return this http2: Make Http2ServerResponse#end() always return this Mar 10, 2019

@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member

lpinca commented Mar 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21388/
@mcollina

mcollina approved these changes Mar 10, 2019
View changes

Copy link
Member

mcollina left a comment

LGTM
@BridgeAR

BridgeAR approved these changes Mar 10, 2019
View changes

@BridgeAR BridgeAR added the author ready label Mar 10, 2019

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Mar 10, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21389/
@cjihrig

cjihrig approved these changes Mar 10, 2019
View changes

@lpinca lpinca referenced this pull request Mar 11, 2019

Closed

http2: compat always return this on .end() #24795

4 of 4 tasks complete

@lpinca lpinca changed the title http2: Make Http2ServerResponse#end() always return this http2: make Http2ServerResponse#end() always return this Mar 11, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@ronag @BridgeAR
http2: `Http2ServerResponse.end()` should always return self 
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
90fdf1b
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 12, 2019

Landed in 90fdf1b 🎉

@BridgeAR BridgeAR closed this Mar 12, 2019

BridgeAR added a commit that referenced this pull request Mar 13, 2019

@ronag @BridgeAR
http2: `Http2ServerResponse.end()` should always return self 
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
348d9a6

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@ronag @BridgeAR
http2: `Http2ServerResponse.end()` should always return self 
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
df4cb3c

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019

@ronag @BridgeAR
http2: `Http2ServerResponse.end()` should always return self 
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
0225a45

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@ronag @BridgeAR
http2: `Http2ServerResponse.end()` should always return self 
PR-URL: #24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
6adcc6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.