★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24333Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark version to v10 from v8 #24333

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@refack refack

@danbev danbev

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
5 participants
@watilde @nodejs-github-bot @richardlau @refack @danbev
@watilde
Copy link
Member

watilde commented Nov 13, 2018

Including the below two updates:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the tools label Nov 13, 2018

@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member

richardlau commented Nov 13, 2018

I think we also need to regenerate tools/lint-md.js.
@watilde

This comment has been minimized.

Sign in to view
Copy link
Member Author

watilde commented Nov 13, 2018

@richardlau That's right. Apparently, lint-md-rollup was always using the latest version by using npm up and I replaced it with npm install to bring the versions under a control. Then I regenerated tools/lint-md.js.

cc @refack
@refack

refack approved these changes Nov 13, 2018
View changes

Copy link
Member

refack left a comment

LGTM
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Nov 13, 2018

I saw make lint-md-rollup as an all-in-one recepie to update lint-md.js. But I agree it makes sense to have a way that deterministically reproduces it...
@watilde

This comment has been minimized.

Sign in to view
Copy link
Member Author

watilde commented Nov 14, 2018

ci: https://ci.nodejs.org/job/node-test-pull-request/18597/
@danbev

danbev approved these changes Nov 16, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Nov 16, 2018

Landed in 62d053b, 195b7c2, and eeed6d9.

@danbev danbev closed this Nov 16, 2018

danbev added a commit that referenced this pull request Nov 16, 2018

@watilde @danbev
tools: update remark version to v10 from v8 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
eeed6d9

danbev added a commit that referenced this pull request Nov 16, 2018

@watilde @danbev
tools: update remark-lint to v6.0.3 from v6.0.2 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
195b7c2

danbev added a commit that referenced this pull request Nov 16, 2018

@watilde @danbev
tools: fix `make lint-md-rollup` and run it 
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Loading status checks…
62d053b

@watilde watilde deleted the watilde:feature/update-remark branch Nov 16, 2018

targos added a commit that referenced this pull request Nov 18, 2018

@watilde @targos
tools: update remark version to v10 from v8 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
f6ea416

targos added a commit that referenced this pull request Nov 18, 2018

@watilde @targos
tools: update remark-lint to v6.0.3 from v6.0.2 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
9bdc1fb

targos added a commit that referenced this pull request Nov 18, 2018

@watilde @targos
tools: fix `make lint-md-rollup` and run it 
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e327b77

rvagg added a commit that referenced this pull request Nov 28, 2018

@watilde @rvagg
tools: update remark version to v10 from v8 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
b9a4bc1

rvagg added a commit that referenced this pull request Nov 28, 2018

@watilde @rvagg
tools: update remark-lint to v6.0.3 from v6.0.2 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
7ffc8b7

rvagg added a commit that referenced this pull request Nov 28, 2018

@watilde @rvagg
tools: fix `make lint-md-rollup` and run it 
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
5748e86

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 12, 2019

@watilde @codebytere
tools: update remark version to v10 from v8 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
16f0f10

codebytere added a commit that referenced this pull request Jan 12, 2019

@watilde @codebytere
tools: update remark-lint to v6.0.3 from v6.0.2 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
ba10955

codebytere added a commit that referenced this pull request Jan 12, 2019

@watilde @codebytere
tools: fix `make lint-md-rollup` and run it 
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
c774baf

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

codebytere added a commit that referenced this pull request Jan 29, 2019

@watilde @codebytere
tools: update remark version to v10 from v8 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
2bed68f

codebytere added a commit that referenced this pull request Jan 29, 2019

@watilde @codebytere
tools: update remark-lint to v6.0.3 from v6.0.2 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
e8e93df

codebytere added a commit that referenced this pull request Jan 29, 2019

@watilde @codebytere
tools: fix `make lint-md-rollup` and run it 
PR-URL: #24333
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
21843c7

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.