★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24303Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: extract listener check as a function #24303

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@fhinkel fhinkel

@jasnell jasnell

@addaleax addaleax

@BridgeAR BridgeAR

@lundibundi lundibundi

Assignees
No one assigned
Labels
events
Projects
None yet
Milestone
No milestone
9 participants
@ZYSzys @mscdex @danbev @fhinkel @jasnell @addaleax @BridgeAR @lundibundi @nodejs-github-bot
@ZYSzys
Copy link
Member

commented Nov 11, 2018

As there are multiple funcions checking the argument listener,so extract listener check as a separate function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the events label Nov 11, 2018

@addaleax

addaleax approved these changes Nov 11, 2018
View changes

@mscdex

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Nov 11, 2018 •
edited

Benchmark CI shows a performance regression with these changes in the events/ee-once.js benchmark.
@BridgeAR

BridgeAR approved these changes Nov 12, 2018
View changes

@lundibundi

lundibundi approved these changes Nov 12, 2018
View changes

@fhinkel

fhinkel approved these changes Nov 13, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18739/
@jasnell

jasnell approved these changes Nov 19, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 19, 2018 •
edited

Re-run of failing node-test-commit-windows-fanned ✔️
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 19, 2018

Landed in a3d9168.

@danbev danbev closed this Nov 19, 2018

danbev added a commit that referenced this pull request Nov 19, 2018

@ZYSzys @danbev
events: extract listener check as a function 
PR-URL: #24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
a3d9168

@ZYSzys ZYSzys deleted the zys-contribs:events/checkListener branch Nov 19, 2018

targos added a commit that referenced this pull request Nov 19, 2018

@ZYSzys @targos
events: extract listener check as a function 
PR-URL: #24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6b93582

rvagg added a commit that referenced this pull request Nov 28, 2018

@ZYSzys @rvagg
events: extract listener check as a function 
PR-URL: #24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
dd89cfe

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 13, 2019

@ZYSzys @codebytere
events: extract listener check as a function 
PR-URL: #24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d94740d

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@ZYSzys @refack
events: extract listener check as a function 
PR-URL: nodejs#24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
9f53d0f

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

MylesBorins added a commit that referenced this pull request Jan 29, 2019

@ZYSzys @MylesBorins
events: extract listener check as a function 
PR-URL: #24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d2dc6f6

codebytere added a commit that referenced this pull request Jan 29, 2019

@ZYSzys @codebytere
events: extract listener check as a function 
PR-URL: #24303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
be56fb7

This was referenced Jan 29, 2019

Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.