src: sort internal binding list #24292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
approved these changes
Nov 10, 2018
| 'util', | ||
| 'uv', | ||
| 'v8', | ||
| 'zlib' |
There was a problem hiding this comment.
would it be possible to put a trailing comma here?
There was a problem hiding this comment.
Possible, yes. But we don't currently have anything that would come after zlib.
richardlau
approved these changes
Nov 10, 2018
jasnell
approved these changes
Nov 10, 2018
lpinca
approved these changes
Nov 11, 2018
starkwang
approved these changes
Nov 12, 2018
|
Nit: commit message subsystem should likely be |
addaleax
approved these changes
Nov 12, 2018
BridgeAR
approved these changes
Nov 12, 2018
fhinkel
approved these changes
Nov 13, 2018
PR-URL: nodejs#24292 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BridgeAR
added a commit
that referenced
this issue
Nov 14, 2018
PR-URL: #24292 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
kiyomizumia
added a commit
to kiyomizumia/node
that referenced
this issue
Nov 15, 2018
PR-URL: nodejs#24292 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
@cjihrig do you have time to backport this to 10.x? |
|
I don't think this applies to 10.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes