★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24289Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document NODE_TLS_REJECT_UNAUTHORIZED #24289

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@BridgeAR BridgeAR

@vsemozhetbyt vsemozhetbyt

@trivikr trivikr

Assignees
No one assigned
Labels
author ready cli doc
Projects
None yet
Milestone
No milestone
9 participants
@cjihrig @nodejs-github-bot @vsemozhetbyt @sam-github @Trott @jasnell @lpinca @BridgeAR @trivikr
@cjihrig
Copy link
Contributor

cjihrig commented Nov 10, 2018

This commit documents the NODE_TLS_REJECT_UNAUTHORIZED environment variable so that the world can know how potentially dangerous it is.

Fixes: #24284

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig
doc: document NODE_TLS_REJECT_UNAUTHORIZED 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.
Verified
This commit was signed with a verified signature.
@cjihrig cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
bf6944b
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added cli doc labels Nov 10, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 10, 2018

Maybe doc/node.1 and lib/internal/print_help.js should also be updated.
@vsemozhetbyt

vsemozhetbyt approved these changes Nov 10, 2018
View changes

@jasnell

jasnell approved these changes Nov 10, 2018
View changes

@lpinca

lpinca approved these changes Nov 11, 2018
View changes

@BridgeAR

BridgeAR approved these changes Nov 12, 2018
View changes

@BridgeAR BridgeAR added the author ready label Nov 12, 2018

@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member

sam-github commented Nov 12, 2018

I don't know how detailed you want to get here, but maybe worth documenting this as only applying to tls.connect() (client side validation of server certs). Perhaps describe it as the default value of rejectUnauthorized for tls.connect().
@trivikr

trivikr approved these changes Nov 13, 2018
View changes

@Trott
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 14, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1607/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 14, 2018

The continued lite CI failure is baffling. It seems impossible that this doc change could be causing a test failure...

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1608/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 14, 2018

Giving up and going with a full CI: https://ci.nodejs.org/job/node-test-pull-request/18606/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 14, 2018

That time linuxone passed! Landing.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 14, 2018

Landed in 9409883

@Trott Trott closed this Nov 14, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 14, 2018

@cjihrig @Trott
doc: document NODE_TLS_REJECT_UNAUTHORIZED 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: nodejs#24289
Fixes: nodejs#24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
9409883

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@cjihrig @BridgeAR
doc: document NODE_TLS_REJECT_UNAUTHORIZED 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: #24289
Fixes: #24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
25065ca

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@cjihrig @kiyomizumia
doc: document NODE_TLS_REJECT_UNAUTHORIZED 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: nodejs#24289
Fixes: nodejs#24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ced4cf7

@oyyd oyyd referenced this pull request Nov 15, 2018

Closed

net: some scattered cleanup #24128

4 of 4 tasks complete

BridgeAR added a commit that referenced this pull request Nov 15, 2018

@cjihrig @BridgeAR
doc: document NODE_TLS_REJECT_UNAUTHORIZED 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: #24289
Fixes: #24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
36e4d0c

@BridgeAR BridgeAR referenced this pull request Nov 15, 2018

Merged

Release proposal: v11.2 #24350

@cjihrig cjihrig deleted the cjihrig:doc branch Nov 15, 2018

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed

This was referenced Nov 16, 2018

Closed
Closed

codebytere added a commit that referenced this pull request Jan 12, 2019

@cjihrig @codebytere
doc: document NODE_TLS_REJECT_UNAUTHORIZED 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: #24289
Fixes: #24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
1ca3c9d

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.