★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24268Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused parameters in function definition #24268

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@danbev danbev

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@tniessen tniessen

@BridgeAR BridgeAR

@starkwang starkwang

Assignees
No one assigned
Labels
async_hooks author ready test
Projects
None yet
Milestone
No milestone
10 participants
@prh1 @Trott @danbev @jasnell @lpinca @cjihrig @tniessen @BridgeAR @starkwang @nodejs-github-bot
@prh1
Copy link
Contributor

prh1 commented Nov 9, 2018

Remove unused parameters triggerAsyncId and resource from oninit function in test-async-await.js.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
@prh1
test: remove unused parameters in function definition 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.
Loading status checks…
383e22f

@nodejs-github-bot nodejs-github-bot added async_hooks test labels Nov 9, 2018

@starkwang

starkwang approved these changes Nov 9, 2018
View changes

@danbev

danbev approved these changes Nov 9, 2018
View changes

@jasnell

jasnell approved these changes Nov 10, 2018
View changes

@lpinca

lpinca approved these changes Nov 10, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 10, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18537/
@BridgeAR

BridgeAR approved these changes Nov 12, 2018
View changes

@BridgeAR BridgeAR added the author ready label Nov 12, 2018

@tniessen

tniessen approved these changes Nov 12, 2018
View changes

Trott added a commit to Trott/io.js that referenced this pull request Nov 12, 2018

@prh1 @Trott
test: remove unused parameters in function definition 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: nodejs#24268
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
49b0f7f
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 12, 2018

Landed in 49b0f7f

@Trott Trott closed this Nov 12, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 12, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@prh1 @BridgeAR
test: remove unused parameters in function definition 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: #24268
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
ea5d184

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@prh1 @kiyomizumia
test: remove unused parameters in function definition 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: nodejs#24268
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bf6e886

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 12, 2019

@prh1 @codebytere
test: remove unused parameters in function definition 
Remove unused parameters triggerAsyncId and resource from oninit
function in test-async-await.js.

PR-URL: #24268
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
d4fd76a

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.