★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24248Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: https agent clientcertengine coverage #24248

Closed
wants to merge 1 commit into from

Conversation

@ovhemert
Copy link
Contributor

commented Nov 8, 2018

Code path for clientCertEngine in getName was not covered by the test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@ovhemert
test: https agent clientcertengine coverage
Loading status checks…
3729ba3

@nodejs-github-bot nodejs-github-bot added the test label Nov 8, 2018

@jasnell
jasnell approved these changes Nov 10, 2018
View changes
@lpinca
lpinca approved these changes Nov 12, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 15, 2018

@ovhemert Can you indicate what line or lines of what file this is intended to add coverage for?
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 15, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18631/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 16, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18669/
@ovhemert

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Nov 16, 2018

It's for covering line 165..167 in lib/https.js:

Agent.prototype.getName = function getName(options) {
  ...
  if (options.clientCertEngine)
    name += options.clientCertEngine;
  ...

It checks that clientCertEngine will be added to the output.

cc: @Trott
@Trott
Trott approved these changes Nov 17, 2018
View changes
Trott added a commit to Trott/io.js that referenced this pull request Nov 17, 2018
@ovhemert @Trott
test: https agent clientcertengine coverage 
PR-URL: nodejs#24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
c3a0337
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 17, 2018

Landed in c3a0337.

@Trott Trott closed this Nov 17, 2018

targos added a commit that referenced this pull request Nov 18, 2018
@ovhemert @targos
test: https agent clientcertengine coverage 
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
8bcc8a1
rvagg added a commit that referenced this pull request Nov 28, 2018
@ovhemert @rvagg
test: https agent clientcertengine coverage 
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cdda7f4
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
Merged
4 of 4 tasks complete
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere added a commit that referenced this pull request Jan 12, 2019
@ovhemert @codebytere
test: https agent clientcertengine coverage 
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
8baad9c
@codebytere codebytere referenced this pull request Jan 15, 2019
Merged
codebytere added a commit that referenced this pull request Jan 29, 2019
@ovhemert @codebytere
test: https agent clientcertengine coverage 
PR-URL: #24248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
8c81992
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@lpinca lpinca

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
5 participants
@ovhemert @Trott @jasnell @lpinca @nodejs-github-bot
You can’t perform that action at this time.