Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesdoc: use real protocol names in ALPN example #24232
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
doc
tls
labels
Nov 7, 2018
mscdex
reviewed
Nov 7, 2018
doc/api/tls.md Outdated
sam-github
force-pushed the
sam-github:use-real-values-for-alpn-protocols
branch
from
0c42fac
to
2b897c8
Nov 9, 2018
This comment has been minimized.
This comment has been minimized.
|
@mscdex PTAL |
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Nov 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in 7cd08eb |
sam-github
closed this
Nov 13, 2018
sam-github
deleted the
sam-github:use-real-values-for-alpn-protocols
branch
Nov 13, 2018
sam-github
added a commit
that referenced
this pull request
Nov 13, 2018
BridgeAR
added a commit
that referenced
this pull request
Nov 14, 2018
kiyomizumia
added a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This was referenced Nov 15, 2018
codebytere
added a commit
that referenced
this pull request
Jan 12, 2019
This was referenced Jan 29, 2019
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sam-github commentedNov 7, 2018
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes