★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24226Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed the arguments order in `assert.strictEqual` #24226

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
backported-to-v10.x code-and-learn test
Projects
None yet
Milestone
No milestone
7 participants
@michael-zucker @gireeshpunathil @Trott @cjihrig @BridgeAR @codebytere @nodejs-github-bot
@michael-zucker
Copy link
Contributor

michael-zucker commented Nov 7, 2018

This change was initiated from the NodeConfEU session.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@michael-zucker
test: fixed the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.
Loading status checks…
db533f8

@nodejs-github-bot nodejs-github-bot added the test label Nov 7, 2018

@BridgeAR

BridgeAR approved these changes Nov 7, 2018
View changes

@BridgeAR BridgeAR added the code-and-learn label Nov 7, 2018

@cjihrig

cjihrig approved these changes Nov 7, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18456/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 10, 2018

failures in arm and smart-os platforms seen yesterday, looks like some infra issues that got fixed.

new CI: https://ci.nodejs.org/job/node-test-pull-request/18480/

Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2018

@michael-zucker @Trott
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
87d0aa8
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 10, 2018

Landed in 87d0aa8

@Trott Trott closed this Nov 10, 2018

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@michael-zucker @amel-true
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
c5f4d1e

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@michael-zucker @rangle-tadhg
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
b40cac6

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@michael-zucker @BridgeAR
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: #24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
4245cbb

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@michael-zucker @kiyomizumia
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cfe32d3

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 13, 2018

@michael-zucker @codebytere
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: #24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
56edd9f

@codebytere codebytere added the backported-to-v10.x label Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@michael-zucker @MylesBorins
test: fix the arguments order in `assert.strictEqual` 
This change was initiated from the NodeConfEU session.

PR-URL: #24226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d7722dd

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.