★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24220Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: support more options in startup benchmark #24220

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@addaleax addaleax

@richardlau richardlau

Assignees
No one assigned
Labels
author ready benchmark test
Projects
None yet
Milestone
No milestone
5 participants
@joyeecheung @nodejs-github-bot @Trott @addaleax @richardlau
@joyeecheung
Copy link
Member

joyeecheung commented Nov 7, 2018

  1. Add options to benchmark the startup performance of a node
    "instance" after running a script. By default there are two options:
    test/fixtures/semicolon which is basically an empty file,
    and benchmark/fixtures/require-cachable which require all
    the cachable modules before exiting. This allows us to measure
    the overhead of bootstrap in more scenarios.
  2. Add options to benchmark the overhead of spinning
    node through a process and through a worker.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@joyeecheung
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.
Verified
This commit was signed with a verified signature.
@joyeecheung joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
ab62bc9
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added benchmark test labels Nov 7, 2018

@joyeecheung joyeecheung referenced this pull request Nov 7, 2018

Closed

src: compile native modules and their code cache in C++ #24221

3 of 3 tasks complete
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

joyeecheung commented Nov 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18400/
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

joyeecheung commented Nov 7, 2018

cc @nodejs/performance
@richardlau

richardlau reviewed Nov 7, 2018
View changes

benchmark/misc/startup.js Outdated
function startNode({ dur }) {
var go = true;
var starts = 0;
function spwanProcess(script) {

This comment has been minimized.

Sign in to view
Copy link
@richardlau

richardlau Nov 7, 2018

Member
Suggested change
function spwanProcess(script) {
function spawnProcess(script) {
benchmark/misc/startup.js Outdated
return spawn(cmd, argv);
}

function spwanWorker(script) {

This comment has been minimized.

Sign in to view
Copy link
@richardlau

richardlau Nov 7, 2018

Member
Suggested change
function spwanWorker(script) {
function spawnWorker(script) {
@addaleax

addaleax approved these changes Nov 7, 2018
View changes

Copy link
Member

addaleax left a comment

Thanks! =)
@joyeecheung
fixup! benchmark: support more options in startup benchmark
Verified
This commit was signed with a verified signature.
@joyeecheung joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
11ddcdb
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

joyeecheung commented Nov 8, 2018

@richardlau Thanks, fixed the typo.

(I don't think I can break anything with this but anyway a new CI): https://ci.nodejs.org/job/node-test-pull-request/18422/

@joyeecheung joyeecheung added the author ready label Nov 8, 2018

@richardlau

richardlau approved these changes Nov 8, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 9, 2018

Landed in 1698fc9

@Trott Trott closed this Nov 9, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 9, 2018

@joyeecheung @Trott
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: nodejs#24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1698fc9

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@joyeecheung @amel-true
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: nodejs#24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2208fb6

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@joyeecheung @rangle-tadhg
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: nodejs#24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
99be106

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@joyeecheung @BridgeAR
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: #24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
ad5c9b4

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@joyeecheung @kiyomizumia
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: nodejs#24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
39e06e8

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 14, 2018

@joyeecheung @codebytere
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: #24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
8c59ebb

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@joyeecheung @MylesBorins
benchmark: support more options in startup benchmark 
1. Add options to benchmark the startup performance of a node
  "instance" after running a script. By default there are two options:
  `test/fixtures/semicolon` which is basically an empty file,
  and `benchmark/fixtures/require-cachable` which require all
  the cachable modules before exiting. This allows us to measure
  the overhead of bootstrap in more scenarios.
2. Add options to benchmark the overhead of spinning
  node through a process and through a worker.

PR-URL: #24220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
0c206e0

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.