★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24208Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: fix writeUInt16BE range check #24208

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@Trott Trott

@addaleax addaleax

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready backported-to-v10.x buffer dont-land-on-v8.x
Projects
None yet
Milestone
No milestone
6 participants
@mscdex @nodejs-github-bot @Trott @addaleax @cjihrig @codebytere
@mscdex
Copy link
Contributor

mscdex commented Nov 6, 2018 •
edited

Fixes: #24205

CI: https://ci.nodejs.org/job/node-test-pull-request/18382/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the buffer label Nov 6, 2018

@Trott

Trott reviewed Nov 6, 2018
View changes

Show resolved Hide resolved lib/internal/buffer.js
@mscdex
buffer: fix writeUInt16BE range check 
Fixes: #24205
Verified
This commit was signed with a verified signature.
@mscdex mscdex mscdex
GPG key ID: 606D7358F94DA209 Learn about signing commits
Loading status checks…
030f2a6

@mscdex mscdex force-pushed the mscdex:buffer-fix-writeUInt16BE branch from 0885ec0 to 030f2a6 Nov 6, 2018

@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@Trott

Trott approved these changes Nov 6, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 6, 2018

CI with test added: https://ci.nodejs.org/job/node-test-pull-request/18383/

@Trott Trott added the author ready label Nov 6, 2018

@addaleax

addaleax approved these changes Nov 7, 2018
View changes

@addaleax addaleax added dont-land-on-v8.x dont-land-on-v10.x labels Nov 7, 2018

@mscdex

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

mscdex commented Nov 7, 2018 •
edited

@addaleax Why would we not land this bug fix on 10.x?
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 7, 2018

@mscdex This adds a throw for some input cases, for which we previously had unintended but consistent behaviour, and addressing this doesn’t seem critical. I would say that that disqualifies this for LTS (or technically even might make this semver-major).

You can feel free to disagree, and remove the labels, if you feel really strongly about this?

@mscdex mscdex removed the dont-land-on-v10.x label Nov 7, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 8, 2018

@mscdex @Trott
buffer: fix writeUInt16BE range check 
Fixes: nodejs#24205

PR-URL: nodejs#24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
5c201b6
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 8, 2018

Landed in 5c201b6.

@Trott Trott closed this Nov 8, 2018

@mscdex mscdex deleted the mscdex:buffer-fix-writeUInt16BE branch Nov 9, 2018

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@mscdex @amel-true
buffer: fix writeUInt16BE range check 
Fixes: nodejs#24205

PR-URL: nodejs#24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
b6b71fd

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@mscdex @rangle-tadhg
buffer: fix writeUInt16BE range check 
Fixes: nodejs#24205

PR-URL: nodejs#24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
a528101

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@mscdex @BridgeAR
buffer: fix writeUInt16BE range check 
Fixes: #24205

PR-URL: #24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
fcc25f9

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@mscdex @kiyomizumia
buffer: fix writeUInt16BE range check 
Fixes: nodejs#24205

PR-URL: nodejs#24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
e36952d

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 13, 2018

@mscdex @codebytere
buffer: fix writeUInt16BE range check 
Fixes: #24205

PR-URL: #24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
f657e40

@codebytere codebytere added the backported-to-v10.x label Dec 13, 2018

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@mscdex @MylesBorins
buffer: fix writeUInt16BE range check 
Fixes: #24205

PR-URL: #24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
9a64cec

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.