★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24204Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable color formatting for test-internal-errors.js #24204

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Reviewers

@bnoordhuis bnoordhuis

@Trott Trott

Assignees
No one assigned
Labels
assert fast-track land-on-v10.x test util
Projects
None yet
Milestone
No milestone
7 participants
@refack @nodejs-github-bot @Trott @danbev @bnoordhuis @codebytere @BridgeAR
@refack
Copy link
Member

refack commented Nov 6, 2018 •
edited

Fixes: #24193
Refs: #19723

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@refack refack referenced this pull request Nov 6, 2018

Closed

Running a single test using --expose-internals throws an error [nodeconf code and learn] #24193

@refack

This comment has been minimized.

Sign in to view
Copy link
Member Author

refack commented Nov 6, 2018

/CC @nodejs/testing @nodejs/assert

@refack refack assigned BridgeAR and refack and unassigned BridgeAR Nov 6, 2018

@refack refack added assert util labels Nov 6, 2018

@refack refack requested a review from BridgeAR Nov 6, 2018

@Trott

Trott approved these changes Nov 6, 2018
View changes

@Trott Trott added the fast-track label Nov 6, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 6, 2018

Collaborators, 👍 here to fast-track.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18380/
@bnoordhuis

bnoordhuis approved these changes Nov 7, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Nov 7, 2018

I'd be happy to merge this, but there is a pending review. Let me know if we don't have to wait. Thanks

@refack refack removed the request for review from BridgeAR Nov 7, 2018

@refack
test: disable color formating for test-internal-errors.js 
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Loading status checks…
18a4550

@refack refack force-pushed the refack:test-with-no-colors branch from 6ace7ec to 18a4550 Nov 7, 2018

@refack

This comment has been minimized.

Sign in to view
Copy link
Member Author

refack commented Nov 7, 2018

I'd be happy to merge this, but there is a pending review. Let me know if we don't have to wait. Thanks

On my part it was more of a request, then a requirement.
But unless there's great urgency, the PRs I prefer to land myself, I self-assign.

@refack refack merged commit 18a4550 into nodejs:master Nov 7, 2018

@refack refack deleted the refack:test-with-no-colors branch Nov 7, 2018

amel-true added a commit to amel-true/node that referenced this pull request Nov 10, 2018

@refack @amel-true
test: disable color formating for test-internal-errors.js 
PR-URL: nodejs#24204
Fixes: nodejs#24193
Refs: nodejs#19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
f1d86f3

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@refack @rangle-tadhg
test: disable color formating for test-internal-errors.js 
PR-URL: nodejs#24204
Fixes: nodejs#24193
Refs: nodejs#19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1f416e9

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@refack @BridgeAR
test: disable color formating for test-internal-errors.js 
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
a2e2c91

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@refack @kiyomizumia
test: disable color formating for test-internal-errors.js 
PR-URL: nodejs#24204
Fixes: nodejs#24193
Refs: nodejs#19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
5807826

This was referenced Nov 15, 2018

Closed
Closed
Closed

This was referenced Nov 16, 2018

Closed
Closed
Closed

@refack refack removed their assignment Nov 16, 2018

codebytere added a commit that referenced this pull request Nov 29, 2018

@refack @codebytere
test: disable color formating for test-internal-errors.js 
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
9814bd9

@codebytere codebytere added the land-on-v10.x label Nov 29, 2018

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@refack @MylesBorins
test: disable color formating for test-internal-errors.js 
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
f20bf8c

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

MylesBorins added a commit that referenced this pull request Dec 3, 2018

@refack @MylesBorins
test: disable color formating for test-internal-errors.js 
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
43097d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.