Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add process no deprecation #24196
Conversation
nodejs-github-bot
added
the
test
label
Nov 6, 2018
addaleax
added
process
code-and-learn
labels
Nov 6, 2018
addaleax
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
richardlau
reviewed
Nov 6, 2018
| const spawn = require('child_process').spawn; | ||
|
|
||
| // spawn self as child | ||
| const child = spawn(process.argv[0], [process.argv[1], 'child']); |
This comment has been minimized.
This comment has been minimized.
richardlau
Nov 6, 2018
Member
Suggested change
| const child = spawn(process.argv[0], [process.argv[1], 'child']); | |
| const child = spawn(process.execPath, [process.argv[1], 'child']); |
lpinca
approved these changes
Nov 6, 2018
| // spawn self as child | ||
| const child = spawn(process.argv[0], [process.argv[1], 'child']); | ||
|
|
||
| child.stderr.setEncoding('utf8'); |
This comment has been minimized.
This comment has been minimized.
razvanbh
force-pushed the
razvanbh:fix-no-deprecation
branch
from
c9fadea
to
097fa62
Nov 7, 2018
jasnell
approved these changes
Nov 10, 2018
|
LGTM with the suggested changes |
razvanbh
added some commits
Nov 6, 2018
razvanbh
force-pushed the
razvanbh:fix-no-deprecation
branch
from
ec8bb0e
to
c0be069
Nov 11, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@richardlau @lpinca PTAL |
gireeshpunathil
added
the
author ready
label
Nov 13, 2018
richardlau
approved these changes
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
|
landed as 6ae6383 , thanks |
gireeshpunathil
closed this
Nov 13, 2018
gireeshpunathil
added a commit
that referenced
this pull request
Nov 13, 2018
BridgeAR
added a commit
that referenced
this pull request
Nov 14, 2018
kiyomizumia
added a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This was referenced Nov 15, 2018
codebytere
added a commit
that referenced
this pull request
Jan 12, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
razvanbh commentedNov 6, 2018
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes