★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24196Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add process no deprecation #24196

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
9 participants
@razvanbh
Copy link
Contributor

razvanbh commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
const spawn = require('child_process').spawn;

// spawn self as child
const child = spawn(process.argv[0], [process.argv[1], 'child']);

This comment has been minimized.

@richardlau

richardlau Nov 6, 2018

Member
Suggested change
const child = spawn(process.argv[0], [process.argv[1], 'child']);
const child = spawn(process.execPath, [process.argv[1], 'child']);
@lpinca

lpinca approved these changes Nov 6, 2018

// spawn self as child
const child = spawn(process.argv[0], [process.argv[1], 'child']);

child.stderr.setEncoding('utf8');

This comment has been minimized.

@lpinca

lpinca Nov 6, 2018

Member
Suggested change
child.stderr.setEncoding('utf8');

@razvanbh razvanbh force-pushed the razvanbh:fix-no-deprecation branch from c9fadea to 097fa62 Nov 7, 2018

@jasnell
Copy link
Member

jasnell left a comment

LGTM with the suggested changes

@razvanbh razvanbh force-pushed the razvanbh:fix-no-deprecation branch from ec8bb0e to c0be069 Nov 11, 2018

@oyyd

This comment has been minimized.

Copy link
Contributor

oyyd commented Nov 13, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 13, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 13, 2018

landed as 6ae6383 , thanks

gireeshpunathil added a commit that referenced this pull request Nov 13, 2018

test: add process no deprecation
PR-URL: #24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR added a commit that referenced this pull request Nov 14, 2018

test: add process no deprecation
PR-URL: #24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

test: add process no deprecation
PR-URL: nodejs#24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

codebytere added a commit that referenced this pull request Jan 12, 2019

test: add process no deprecation
PR-URL: #24196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.