console: cover .assert with single argument #24188
Closed
Conversation
addaleax
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
jasnell
approved these changes
Nov 10, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18537/ |
Trott
added a commit
to Trott/io.js
that referenced
this issue
Nov 11, 2018
PR-URL: nodejs#24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in e3d05a6. |
BridgeAR
added a commit
that referenced
this issue
Nov 14, 2018
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia
added a commit
to kiyomizumia/node
that referenced
this issue
Nov 15, 2018
PR-URL: nodejs#24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
that referenced
this issue
Dec 14, 2018
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
added a commit
that referenced
this issue
Dec 26, 2018
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR covers
console.assertwith a single argument.See https://coverage.nodejs.org/coverage-d32b5bd567544f5b/root/console.js.html#L295
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe text was updated successfully, but these errors were encountered: