test: assert diff no color #24181
test: assert diff no color #24181
Conversation
Can you add a comment explaining what is being tested? The test passes (in my environment at least) even without the NODE_DISABLE_COLORS or with that environment variable set to false. (EDIT: More explanation below about why the test is passing regardless of env variable setting.)
| process.env.NODE_DISABLE_COLORS = true; | ||
|
|
||
| try { | ||
| assert.strictEqual(1, 3); |
There was a problem hiding this comment.
This won't normally result in colorized output, at least not in my environment. assert.deepStrictEqual({a: 'a'}, {}) will do the trick.
|
OK, so the To get colorized output, maybe try something like |
|
Hi @Trott. Thanks for pointing that out. I did a rocky mistake. When I first ran the test it was with a node version installed locally (10.13.0) not with the version from master. That version had colors and a different text on strictEqual. When I found out that I had to run with I will update the pull request and add some description about the test case |
|
I made the changes. |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18585/ |
|
Landed in a2c2c78 |
PR-URL: nodejs#24181 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24181 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#24181 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
This pull request adds a test that covers lines 313-316 from
root/internal assert.js. Specifically it tests the scenario when the tty does not support colors and the assert messages should not be decorated.I emulated the scenario by setting the environment variable
NODE_DISABLE_COLORStotruemake -j4 test(UNIX), orvcbuild test(Windows) passes