★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24178Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed order of actual and expected arguments #24178

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
code-and-learn test
Projects
None yet
Milestone
No milestone
7 participants
@kiyomizumia @gireeshpunathil @jasnell @cjihrig @BridgeAR @addaleax @nodejs-github-bot
@kiyomizumia
Copy link
Contributor

kiyomizumia commented Nov 6, 2018

Contributed at NodeconfEU:

changed to assertStrictEqual parameters to correct order on line 77 and line 80.

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 6, 2018
View changes

@addaleax addaleax added the code-and-learn label Nov 6, 2018

@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18452/
@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member

jasnell commented Nov 10, 2018

CI failures appear unrelated. Resuming:https://ci.nodejs.org/job/node-test-pull-request/18502/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 12, 2018

Resume CI (on arm): https://ci.nodejs.org/job/node-test-commit-arm-fanned/4288/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 12, 2018

landed as e39aba1

thank you @kiyomizumia for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 12, 2018

gireeshpunathil added a commit that referenced this pull request Nov 12, 2018

@kiyomizumia @gireeshpunathil
test: fixed order of actual and expected arguments 
PR-URL: #24178
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Loading status checks…
e39aba1

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@kiyomizumia @BridgeAR
test: fixed order of actual and expected arguments 
PR-URL: #24178
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
1a86499

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Jan 12, 2019

@kiyomizumia @codebytere
test: fixed order of actual and expected arguments 
PR-URL: #24178
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
Loading status checks…
8728361

@codebytere codebytere referenced this pull request Jan 15, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Jan 30, 2019

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.