★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24172Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assert.strictEqual argument order #24172

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
code-and-learn test
Projects
None yet
Milestone
No milestone
8 participants
@mcqj @gireeshpunathil @jasnell @addaleax @cjihrig @BridgeAR @trivikr @nodejs-github-bot
@mcqj
Copy link
Contributor

mcqj commented Nov 6, 2018

The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@mcqj
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js
Loading status checks…
a0e8faa

@nodejs-github-bot nodejs-github-bot added the test label Nov 6, 2018

@cjihrig

cjihrig approved these changes Nov 6, 2018
View changes

@gireeshpunathil

gireeshpunathil approved these changes Nov 6, 2018
View changes

@addaleax addaleax added the code-and-learn label Nov 6, 2018

@addaleax

addaleax approved these changes Nov 6, 2018
View changes

@BridgeAR

BridgeAR approved these changes Nov 6, 2018
View changes

@trivikr

trivikr approved these changes Nov 7, 2018
View changes

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18451/
@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member

jasnell commented Nov 10, 2018

CI failure appears to be unrelated... resumed: https://ci.nodejs.org/job/node-test-pull-request/18503/ (the link is not currently active as the CI is catching up on a few other jobs... the resume job should be created soon)
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member

gireeshpunathil commented Nov 11, 2018

landed as 5ad4c44

thank you @mcqj for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

@gireeshpunathil gireeshpunathil closed this Nov 11, 2018

gireeshpunathil added a commit that referenced this pull request Nov 11, 2018

@mcqj @gireeshpunathil
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

PR-URL: #24172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
5ad4c44

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018

@mcqj @rangle-tadhg
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

PR-URL: nodejs#24172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
28ffc41

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@mcqj @BridgeAR
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

PR-URL: #24172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
768425f

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@mcqj @kiyomizumia
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

PR-URL: nodejs#24172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
fac182f

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 14, 2018

@mcqj @codebytere
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

PR-URL: #24172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
07c6db9

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@mcqj @MylesBorins
test: fix assert.strictEqual argument order 
The arguments to assert.strictEqual in a number of calls were in the
wrong order. It is preferred that literal values are in the second
argument.

Updates test/parallel/test-fs-readStream.js

PR-URL: #24172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
3bb6372

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.